Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken URLs #6295

Merged
merged 18 commits into from
Sep 15, 2024
Merged

Fix broken URLs #6295

merged 18 commits into from
Sep 15, 2024

Conversation

bernt-matthias
Copy link
Contributor

Requires: #6184

TODO:

  • bump tools versions

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

@mvdbeek
Copy link
Member

mvdbeek commented Sep 3, 2024

I wouldn't bump the version or deploy the tools, I think it's fine to just do that when there is a relevant change on the next update ?

@bernt-matthias
Copy link
Contributor Author

I wouldn't bump the version or deploy the tools, I think it's fine to just do that when there is a relevant change on the next update ?

Would be fine for me. But I have the feeling that we should document the rules when to bump / not. Sometimes people say always. Sometimes there are exceptions.

@bgruening
Copy link
Member

I would not bump if we do not deploy. If we deploy we bump.

I would not deploy and not bump this PR. We just want to fix the linters and I think it fine to deploy with the next proper release.

@bernt-matthias
Copy link
Contributor Author

OK. Let's merge and skip deployment.

@bernt-matthias
Copy link
Contributor Author

We still have timeouts with archived versions of http://www.ebi.ac.uk/~zerbino/velvet/, i.e. https://web.archive.org/web/20170704005814/http://www.ebi.ac.uk/~zerbino/velvet/

Oddly not for https://web.archive.org/web/20170715194744/http://www.ebi.ac.uk/~zerbino/velvet/Manual.pdf

Anyone ideas? Would be good to have linting passing :)

@nsoranzo
Copy link
Member

remove _Velvet which seems unused anyway

use githum manual
@bgruening
Copy link
Member

Lint is green!

@bgruening bgruening merged commit 3d8e0f1 into galaxyproject:main Sep 15, 2024
6 of 10 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Sep 15, 2024

Attention: deployment cancelled!

https://github.com/galaxyproject/tools-iuc/actions/runs/10869685320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants