Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final paper edits #79

Merged
merged 7 commits into from
Mar 19, 2024
Merged

Final paper edits #79

merged 7 commits into from
Mar 19, 2024

Conversation

supernord
Copy link
Collaborator

@supernord supernord requested review from bebatut and paulzierep March 14, 2024 21:56
Copy link
Contributor

@matuskalas matuskalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🙌🏽🙌🏽 Giant thanks for debugging & fixing all this!!! 🙏🏽🙏🏽

One issue left is that some of the citations lack proper capitalisation in their titles (e.g. "galaxy") . Double curly brackets in all titles should fix that.

And "others" in the list of authors renders weirdly; we could rather replace by the full lists of authors.

I'm happy to fix those, but probably won't manage before Friday night or Monday.

And a question: Should the ToolShed article be cited (also) as usesDataFrom? Or do we in fact not use any data from it, only from the repos with wrappers?

@supernord
Copy link
Collaborator Author

Thanks @matuskalas
If you make those edits, I can create a final preview and then submit.

Copy link
Contributor

@matuskalas matuskalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm doing the needed edits in the .bib, which will be a separate, non-conflicting PR. So this one can in my opinion be merged.

The only question I have left here, and it is not important (It's more my own curiosity):
Should the ToolShed article be cited (also) as usesDataFrom? Or do we in fact not use any data from it, only from the repos with wrappers?

@supernord
Copy link
Collaborator Author

@paulzierep - what do you think about the toolshed reference?

@paulzierep
Copy link
Collaborator

I'm doing the needed edits in the .bib, which will be a separate, non-conflicting PR. So this one can in my opinion be merged.

The only question I have left here, and it is not important (It's more my own curiosity): Should the ToolShed article be cited (also) as usesDataFrom? Or do we in fact not use any data from it, only from the repos with wrappers?

The Tool Metadata Extractor does not use the ToolShed at all. As an explanation: currently it is not really useful for us since we cannot get the metadata we want via the API, that's why we scrape the wrapper code directly. So I think the current reference is fine.

Copy link
Collaborator

@paulzierep paulzierep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it renders fine, it is good to go ! Thank you all for the help and support!

@bebatut
Copy link
Member

bebatut commented Mar 19, 2024

Should we discuss the author's order?

Cite QIIME 2 instead of mothur?
@supernord supernord merged commit 93643eb into main Mar 19, 2024
4 checks passed
neoformit pushed a commit to nomadscientist/galaxy_codex that referenced this pull request Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants