Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Genome and Proteomics labs #167

Merged
merged 20 commits into from
Oct 3, 2024
Merged

Conversation

neoformit
Copy link
Collaborator

@neoformit neoformit commented Aug 29, 2024

@neoformit
Copy link
Collaborator Author

@paulzierep

@neoformit
Copy link
Collaborator Author

Will need revision after #169 merges

@neoformit
Copy link
Collaborator Author

Have refactored to match the new structure @paulzierep

@neoformit
Copy link
Collaborator Author

@bebatut

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some files left the labs folder. Could they move?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The labs/assets folder is for global assets that are used by multiple labs, so it doesn't make sense for them to live in any particular lab. We also agreed that we could have a top-level labs folder with links to all existing labs, so the labs are easier to find.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The labs/assets folder is for global assets that are used by multiple labs, so it doesn't make sense for them to live in any particular lab.

The labs/assets folder could go in sources folder` like the HTML templates for pages

We also agreed that we could have a top-level labs folder with links to all existing labs, so the labs are easier to find.

Links to all existing labs would be good in communities/all we store resources shared by different communities. What do you think?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links to all existing labs would be good in communities/all

Ok, how about communities/all/labs/? Could I just put the assets in there too, so the labs stuff is all in one place? That makes a lot more sense to me than mixing the "labs" and "tool usage" files together. Plus, these are assets for "all communities' labs" so I think the path name is logical.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@bebatut bebatut merged commit bc25a73 into galaxyproject:main Oct 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants