-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Genome and Proteomics labs #167
Conversation
Will need revision after #169 merges |
Have refactored to match the new structure @paulzierep |
labs/assets/site-switcher.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some files left the labs
folder. Could they move?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The labs/assets folder is for global assets that are used by multiple labs, so it doesn't make sense for them to live in any particular lab. We also agreed that we could have a top-level labs
folder with links to all existing labs, so the labs are easier to find.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The labs/assets folder is for global assets that are used by multiple labs, so it doesn't make sense for them to live in any particular lab.
The labs/assets folder could go in sources
folder` like the HTML templates for pages
We also agreed that we could have a top-level
labs
folder with links to all existing labs, so the labs are easier to find.
Links to all existing labs would be good in communities/all
we store resources shared by different communities. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Links to all existing labs would be good in communities/all
Ok, how about communities/all/labs/
? Could I just put the assets
in there too, so the labs stuff is all in one place? That makes a lot more sense to me than mixing the "labs" and "tool usage" files together. Plus, these are assets for "all communities' labs" so I think the path name is logical.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Two new Galaxy Labs (subdomains) that I've migrated from Galaxy AU.
The Lab pages can be seen rendered here:
https://labs.usegalaxy.org.au/?content_root=https://github.com/neoformit/galaxy_codex/blob/add-labs/communities/genome/lab/base.yml
https://labs.usegalaxy.org.au/?content_root=https://github.com/neoformit/galaxy_codex/blob/add-labs/communities/proteomics/lab/base.yml
Note that after merging this PR, these URLs will change to:
https://labs.usegalaxy.org.au/?content_root=https://github.com/galaxyproject/galaxy_codex/blob/main/communities/genome/lab/base.yml
https://labs.usegalaxy.org.au/?content_root=https://github.com/galaxyproject/galaxy_codex/blob/main/communities/proteomics/lab/base.yml
I have also updated the single cell lab README and renamed
communities/spoc/subdomain
tocommunities/spoc/lab
, therefore the final "resting place" for the Single-Cell lab after merging this will be:https://labs.usegalaxy.org.au/?content_root=https://github.com/galaxyproject/galaxy_codex/blob/main/communities/spoc/lab/base.yml