Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.2] Fix social_core methods #17530

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Feb 22, 2024

Should fix #17508, for real this time.

These were cleverly refactored in #16724, and that broke things because the methods are used by social_core. I've restored the original behavior and added comments to each method to prevent future 'optimizations". I've rearranged the methods to mirror the parent class in social_core/storage.py (in .venv).

Also see #17516.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs jdavcs added kind/bug area/auth Authentication and authorization labels Feb 22, 2024
@github-actions github-actions bot added this to the 23.2 milestone Feb 22, 2024
@mvdbeek mvdbeek merged commit 51ee56e into galaxyproject:release_23.2 Feb 23, 2024
43 of 46 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Feb 23, 2024

Thank you @jdavcs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/auth Authentication and authorization kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants