Serious problems with open id connect authentication #17508
Comments
|
@jdavcs can you take a look at this ? |
|
@vazovn Thank you for the very detailed report - this was very helpful! Definitely a bug - sorry about that! Could you please try the solution in #17516? I know you've mentioned that a similar error happens on the call to |
|
Any chance you could provide the complete traceback @vazovn ? |
|
I will do this in 10 mins. I had other issues this morning. |
|
Hi, again, John's fix corrected the try - except block bug. Now the This method is called by where The "init.py's" get method returns scalared stmt: which fails in the method The entire debug log is here: I am afraid that this issue might affect other methods which communicate with the database via galaxy + third party modules like in our case |
|
@vazovn it should be fixed in #17516. This one was a curious gotcha. The code Thanks again for the detailed report! |
|
Hi, unfortunately the issue is far from being solved ... The second fix (#17516 - adding I found out that the method It is only found in I tried to play with it today, by implementing it in Can you have a look at the error log I sent here above? I guess that |
|
Yep, that's refactoring went bad. Fixing now. |
|
Thank you! I appreciate your quick reaction. We have some users who are pushing us in turn :-) |
|
Hi, John, The last bix fix did the job. I can now log in. We are using ansible to deploy with How shall I get hold of the fix then? Thank you very much. Actually there seem to be other issues which fail, but they are not related to openidc. I will start a new issue for them. Best regards Nikolay |
|
Nikolay - Can you point it to the latest version of the |
|
Thank you, will try tomorrow! Getting a but late here. Thank you very much, John. |
|
I think so, yes. Ping me if it doesn't work, or if all breaks again :-) |
That tag corresponds to the the very first commit after making the release and means you're always on the commit of the branch that received the least bugfixes. You're best off simply setting |
|
Closing this as completed (#17530). Please feel free to reopen if needed. |
Describe the bug
After the upgrade from 23.1 to 23.2 the authentication by open idc is not possible.
Galaxy Version and/or server at which you observed the bug
Galaxy Version: 23.2
Commit: 9c593cd
To Reproduce
The entire
class PSAAssociation(Base, AssociationMixin, RepresentById):in../lib/galaxy/model/__init__.pyseems to be failing. I have encountered the following generic issue :23.1 makes use of indexes when interacting with the database (table
psa_association). These are compatible with the parent classes in../venv/lib/python3.11/site-packages/social_core/backends/open_id_connect.pywhich also use indexes to handle subscriptable results.For example:
is OK and the IndexError captures the errors correctly
23.2 in turn has been modified to use scalars and the calls to the parent class fail
fails, because the method
first()returnsNoneand notFalseand the error is never captured as IndexError.If changed to
it seems to be working.
Without the change above the
assocobject is simply not created!However, the problems continue after this fix:
The flow continues in
../lib/galaxy/model/__init__.pyand gets toand throws another error again in the parent
class OpenIdConnectAuth(BaseOAuth2)in../venv/lib/python3.11/site-packages/social_core/backends/open_id_connect.pyat
return self.strategy..again with an error due to scalar VS subscriptable incompatibility.
Converting to list sort of solves the error but later fails again with similar issues.
Expected behavior
These errors actually disable completely our galaxy instance which blocks the possibility for the users to log in. It is actually very unfortunate.
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: