Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update carbon emissions methodology page to match current feature spe… #16392

Conversation

Renni771
Copy link
Contributor

Addresses #15046. Admin configuration options were added in PR #16307. This PR update the methodology page to match the current implementation spec, in particular how admins configure the server's geographical location and how the carbon intensity value used in the calculations corresponds to that value. This PR also mentions how admins can set custom PUE values and how these values are used in the calculations.

What else changed/fixed:

  • Typos.
  • Some sentences were reworded.
  • The old spec mentioned that server hardware information is used when provided. Galaxy doesn't support this right now, so I took that out and mentioned that to the users for transparency. I also explain how we use AWS estimates since the current implementation is based solely on that.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@Renni771 Renni771 marked this pull request as ready for review July 13, 2023 09:01
@github-actions github-actions bot added this to the 23.2 milestone Jul 13, 2023
@bgruening bgruening merged commit a5c3275 into galaxyproject:dev Jul 14, 2023
@bgruening
Copy link
Member

Thanks @Renni771

@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

@Renni771 Renni771 deleted the update-carbon-emissions-reporting-methodology-page branch January 11, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants