Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] GSoC Blog: Robin Roy (Community Bonding) #890

Merged
merged 4 commits into from
Jun 3, 2024

Conversation

robinroy03
Copy link
Member

@robinroy03 robinroy03 commented May 29, 2024

My community bonding period blog.

Also fixed a 2021 blog typo. Codespell was flagging them.

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.37%. Comparing base (da7d735) to head (a7f428e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #890   +/-   ##
=======================================
  Coverage   84.37%   84.37%           
=======================================
  Files          44       44           
  Lines       10553    10553           
  Branches     1432     1432           
=======================================
  Hits         8904     8904           
  Misses       1270     1270           
  Partials      379      379           

Copy link

@itellaetxe itellaetxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work in your CB period Robin!! Super productive

The blog LGTM, only one small issue with the title markers

docs/source/posts/2024/2024-05-28-week-0-robin.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@deka27 deka27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks fine to me.

Really love what you are doing, looking forward to future updates.

@robinroy03 robinroy03 requested review from itellaetxe and deka27 May 29, 2024 13:48
@deka27
Copy link
Contributor

deka27 commented May 29, 2024

I think you should squash your commits. This will help in a clear commit history.

@robinroy03
Copy link
Member Author

@deka27 commits squashed 👍

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @robinroy03,

Thank for this! See below my first comment

docs/source/posts/2024/2024-05-28-week-0-robin.rst Outdated Show resolved Hide resolved
docs/source/posts/2024/2024-05-28-week-0-robin.rst Outdated Show resolved Hide resolved
docs/source/posts/2024/2024-05-28-week-0-robin.rst Outdated Show resolved Hide resolved
docs/source/posts/2024/2024-05-28-week-0-robin.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @robinroy03,

See below my last comment.

Can you also rebase your PR. Thank you

docs/source/posts/2024/2024-05-28-week-0-robin.rst Outdated Show resolved Hide resolved
docs/source/posts/2024/2024-05-28-week-0-robin.rst Outdated Show resolved Hide resolved
docs/source/posts/2024/2024-05-28-week-0-robin.rst Outdated Show resolved Hide resolved
@robinroy03 robinroy03 requested a review from skoudoro May 30, 2024 17:12
@m-agour
Copy link
Contributor

m-agour commented Jun 1, 2024

Hi @skoudoro @robinroy03
This blog post It renders without any problems and videos are working great!

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All ok, merging

@skoudoro skoudoro merged commit 858fc89 into fury-gl:master Jun 3, 2024
29 of 31 checks passed
@robinroy03 robinroy03 deleted the gsoc_docs branch June 6, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants