-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] GSoC Blog: Robin Roy (Community Bonding) #890
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #890 +/- ##
=======================================
Coverage 84.37% 84.37%
=======================================
Files 44 44
Lines 10553 10553
Branches 1432 1432
=======================================
Hits 8904 8904
Misses 1270 1270
Partials 379 379 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work in your CB period Robin!! Super productive
The blog LGTM, only one small issue with the title markers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks fine to me.
Really love what you are doing, looking forward to future updates.
I think you should squash your commits. This will help in a clear commit history. |
@deka27 commits squashed 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @robinroy03,
Thank for this! See below my first comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @skoudoro @robinroy03 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All ok, merging
My community bonding period blog.
Also fixed a 2021 blog typo. Codespell was flagging them.