-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TYPO] Typo fix in code #891
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
Because you included the typo fix of the 2021 blog in #890, this should be enough to address the rest of the codespell issues. Approving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #891 +/- ##
==========================================
- Coverage 84.37% 84.37% -0.01%
==========================================
Files 44 44
Lines 10556 10553 -3
Branches 1432 1432
==========================================
- Hits 8907 8904 -3
Misses 1270 1270
Partials 379 379
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, we have one less CI error now. Approving
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this @robinroy03!
Looks good to me, merging
Thank you for all reviews |
Typo fixes in
fury/gltf.py
andfury/tests/test_stream.py
.codespell
was flagging them while making GSoC blogs.This CI in
codespell
is flagging a typo which I've fixed inside #890