Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TYPO] Typo fix in code #891

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

robinroy03
Copy link
Member

@robinroy03 robinroy03 commented May 29, 2024

Typo fixes in fury/gltf.py and fury/tests/test_stream.py.

codespell was flagging them while making GSoC blogs.

This CI in codespell is flagging a typo which I've fixed inside #890

Copy link

@itellaetxe itellaetxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.
Because you included the typo fix of the 2021 blog in #890, this should be enough to address the rest of the codespell issues. Approving.

Copy link
Contributor

@deka27 deka27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.37%. Comparing base (daba6ce) to head (c8ef55b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #891      +/-   ##
==========================================
- Coverage   84.37%   84.37%   -0.01%     
==========================================
  Files          44       44              
  Lines       10556    10553       -3     
  Branches     1432     1432              
==========================================
- Hits         8907     8904       -3     
  Misses       1270     1270              
  Partials      379      379              
Files Coverage Δ
fury/gltf.py 79.58% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@WassCodeur WassCodeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, we have one less CI error now. Approving

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @robinroy03!

Looks good to me, merging

@skoudoro
Copy link
Contributor

Thank you for all reviews

@skoudoro skoudoro merged commit da7d735 into fury-gl:master May 29, 2024
26 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants