Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change legacy string formatting to f-strings #1374

Merged
merged 8 commits into from
Oct 4, 2023
Merged

Change legacy string formatting to f-strings #1374

merged 8 commits into from
Oct 4, 2023

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

@DimitriPapadopoulos DimitriPapadopoulos force-pushed the f-strings branch 6 times, most recently from 75f407c to acdff6c Compare September 21, 2023 19:14
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review September 21, 2023 19:54
@martindurant
Copy link
Member

Sorry, it will take me a little time to check all of these little changes.
Was this automatically generated?

@DimitriPapadopoulos
Copy link
Contributor Author

Not 100% automatically, because:

  • pyupgrade cannot apply one category of changes only, which I find easier to review and merge,
  • sometimes pyupgrade does not modernise as much as possible, for example using f-strings.

martindurant
martindurant reviewed Sep 28, 2023
View reviewed changes
Copy link
Member

@martindurant martindurant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am more than halfway through, just a few very small things so far,

fsspec/implementations/jupyter.py Outdated Show resolved Hide resolved
fsspec/implementations/jupyter.py Outdated Show resolved Hide resolved
fsspec/implementations/jupyter.py Outdated Show resolved Hide resolved
fsspec/implementations/local.py Outdated Show resolved Hide resolved
fsspec/implementations/local.py Outdated Show resolved Hide resolved
fsspec/implementations/sftp.py Outdated Show resolved Hide resolved
@martindurant
Copy link
Member

That was weird, had to rerun many test runs before they passed. Perhaps dockerhub was having a bad day...

This is going in now.

@martindurant martindurant merged commit edf9b73 into fsspec:master Oct 4, 2023
11 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the f-strings branch October 4, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martindurant martindurant martindurant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @martindurant