Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: renaming standaloneDeployment variable to be consistent #5183

Closed
wants to merge 1 commit into from
+5 −5
Closed

fix: renaming standaloneDeployment variable to be consistent #5183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/flyte-core/templates/admin/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ spec:
{{- end }}
{{- end }}
{{- end }}
{{- if and (.Values.cluster_resource_manager.enabled) (not .Values.cluster_resource_manager.standalone_deploy) }}
{{- if and (.Values.cluster_resource_manager.enabled) (not .Values.cluster_resource_manager.standaloneDeployment) }}
- command:
- flyteadmin
- --config
Expand Down
2 changes: 1 addition & 1 deletion charts/flyte-core/values-eks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ cluster_resource_manager:
# -- Enables the Cluster resource manager component
enabled: true
# -- Starts the cluster resource manager in standalone mode with requisite auth credentials to call flyteadmin service endpoints
standalone_deploy: false
standaloneDeployment: false
config:
cluster_resources:
customData:
Expand Down
2 changes: 1 addition & 1 deletion charts/flyte-core/values-gcp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ cluster_resource_manager:
# -- Enables the Cluster resource manager component
enabled: true
# -- Starts the cluster resource manager in standalone mode with requisite auth credentials to call flyteadmin service endpoints
standalone_deploy: false
standaloneDeployment: false
config:
cluster_resources:
customData:
Expand Down
4 changes: 2 additions & 2 deletions docs/deployment/plugins/k8s/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,7 +623,7 @@ Specify plugin configuration
spark: spark
cluster_resource_manager:
enabled: true
standalone_deploy: false
standaloneDeployment: false
# -- Resource templates that should be applied
templates:
# -- Template for namespaces resources
Expand Down Expand Up @@ -735,7 +735,7 @@ Specify plugin configuration
spark: spark
cluster_resource_manager:
enabled: true
standalone_deploy: false
standaloneDeployment: false
config:
cluster_resources:
customData:
Expand Down
Loading