-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: renaming standaloneDeployment variable to be consistent #5183
fix: renaming standaloneDeployment variable to be consistent #5183
Conversation
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Signed-off-by: Nuno Martins <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5183 +/- ##
==========================================
+ Coverage 59.06% 59.08% +0.01%
==========================================
Files 646 646
Lines 55726 55739 +13
==========================================
+ Hits 32916 32934 +18
+ Misses 20214 20209 -5
Partials 2596 2596
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cc @davidmirror-ops to review the charts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cluster_resource_manager could be deployed twice as part of flyteadmin and standalone
Do you think this is still the case with the changes you're proposing?
Thanks!
@davidmirror-ops
? (in contrast to this line) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delays. Thank you!
@TresTristesTrigues sorry, I think we should have merged this. Any chance we can still make it happen? |
This PR fixes 2 issues: