Support Azure Cloud Provider (via Stow) #4328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Signed-off-by: Chris Grass <[email protected]>
2 tasks
davidmirror-ops
approved these changes
Nov 21, 2023
eapolinario
approved these changes
Nov 21, 2023
eapolinario
merged commit aff9750
into
flyteorg:bump-stow-to-0.3.8
14 of 15 checks passed
|
Congrats on merging your first pull request! 🎉 |
EngHabu
added a commit
that referenced
this pull request
Nov 28, 2023
* Bump flyteorg/stow to 0.3.8 Signed-off-by: Eduardo Apolinario <[email protected]> * Update configmap and helper to support azure storage (#4328) * go mod tidy Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update stow in flytestdlib Signed-off-by: Eduardo Apolinario <[email protected]> --------- Signed-off-by: Eduardo Apolinario <[email protected]> Signed-off-by: Haytham Abuelfutuh <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]> Co-authored-by: cgrass <[email protected]> Co-authored-by: Haytham Abuelfutuh <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Check all the applicable boxes
Screenshots
Note to reviewers
This will allow users of the
flyte-binarychart to configure Azure storage accounts. The stow version bump is needed in order to use Workload Identity.This PR does not include an implementation of RemoteURLInterface, which would be required before using signed URLs in Azure. A potential fix is being discussed in slack and should not be difficult, but I'm not confident that support for signed URLs is required.
A storage key or workload identity needs to be configured for this to work end-to-end with task pods and azure blob storage via Stow. A workflow identity can be defined in the PodTemplate like this example, and the service can be deployed using a values.yaml similar to here. Should that configuration be documented in some other way?