remove type from values file. update docs for 'key'.

flyteorg · Oct 31, 2023 · bf62b2c · bf62b2c
1 parent f6eb3fc
commit bf62b2c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/charts/flyte-binary/README.md b/charts/flyte-binary/README.md
@@ -69,7 +69,6 @@ Chart for basic single Flyte executable deployment
 | configuration.storage.providerConfig.azure.account | string | `"storage-account-name"` |  |
 | configuration.storage.providerConfig.azure.configDomainSuffix | string | `""` |  |
 | configuration.storage.providerConfig.azure.configUploadConcurrency | int | `4` |  |
-| configuration.storage.providerConfig.azure.type | string | `"stow"` |  |
 | configuration.storage.providerConfig.gcs.project | string | `"my-organization-gcp-project"` |  |
 | configuration.storage.providerConfig.s3.accessKey | string | `""` |  |
 | configuration.storage.providerConfig.s3.authType | string | `"iam"` |  |

diff --git a/charts/flyte-binary/templates/configmap.yaml b/charts/flyte-binary/templates/configmap.yaml
@@ -118,8 +118,8 @@ data:
           {{- if .key }}
           key: {{ .key }}
           {{- end }}
-          {{- if .ConfigDomainSuffix }}
-          configDomainSuffix: {{ .ConfigDomainSuffix }}
+          {{- if .configDomainSuffix }}
+          configDomainSuffix: {{ .configDomainSuffix }}
           {{- end }}
           {{- if .ConfigUploadConcurrency }}
           configUploadConcurrency: {{ .ConfigUploadConcurrency }}

diff --git a/charts/flyte-binary/values.yaml b/charts/flyte-binary/values.yaml
@@ -87,9 +87,10 @@ configuration:
         configDomainSuffix: ""
         # configUploadConcurrency Upload Concurrency (default 4)
         configUploadConcurrency: 4
-        type: stow
         # account Storage Account name
         account: "storage-account-name"
+        # key Storage Account key if used
+        #key: ""
   # logging Specify configuration for logs emitted by Flyte
   logging:
     # level Set the log level