Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address various issues throughout code base #4329

Merged
merged 14 commits into from
Oct 17, 2023
Merged

Address various issues throughout code base #4329

merged 14 commits into from
Oct 17, 2023

Conversation

hiddeco
Copy link
Member

@hiddeco hiddeco commented Oct 13, 2023

No description provided.

@hiddeco hiddeco marked this pull request as ready for review October 13, 2023 08:57
@hiddeco hiddeco requested a review from a team October 16, 2023 11:29
stefanprodan
stefanprodan approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

darkowlzz
darkowlzz approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I'll update #4311 which used the old ConditionFunc to ConditionWithContextFunc for wait poll.

hiddeco added 14 commits October 17, 2023 14:07
@hiddeco
misc: address strings.Title deprecation
16d352b 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
misc: handle undhandled error
b67a463 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
misc: address unnecessary use of fmt.Sprintf
3c49586 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
misc: use raw string for regex to avoid double esc
a2a3b4f 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
misc: address double import
43c2359 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
misc: simplify row append
3278a07 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
misc: address kustomize/api/filesys deprecation
5b22207 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
misc: unconditional strings.TrimPrefix
ce3e264 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
misc: use errors.As instead of type checking
22134b1 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
misc: address wait.PollImmediate deprecation
3fdb292 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
misc: remove unused bits of code
f5d3283 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
misc: sinceSeconds -> sinceDuration
e3f6f0f 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
misc: fix hypothetical implicit memory aliasing
ba1180a 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco
misc: clean up immediately and avoid delayed defer
f137263 
Signed-off-by: Hidde Beydals <[email protected]>
@hiddeco hiddeco merged commit 5f1fe30 into main Oct 17, 2023
8 checks passed
@hiddeco hiddeco deleted the tidy-nits branch October 17, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

@darkowlzz darkowlzz darkowlzz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hiddeco @darkowlzz @stefanprodan