misc: clean up immediately and avoid delayed defer

Signed-off-by: Hidde Beydals <[email protected]>
fluxcd · Oct 17, 2023 · 0ed738d · 0ed738d
1 parent 30fcaa2
commit 0ed738d
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/internal/build/diff.go b/internal/build/diff.go
@@ -116,13 +116,14 @@ func (b *Builder) Diff() (string, bool, error) {
 			if err != nil {
 				return "", createdOrDrifted, err
 			}
-			defer cleanupDir(tmpDir)
 
 			err = diff(liveFile, mergedFile, &output)
 			if err != nil {
+				cleanupDir(tmpDir)
 				return "", createdOrDrifted, err
 			}
 
+			cleanupDir(tmpDir)
 			createdOrDrifted = true
 		}