Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webview_flutter] Add ewk_set_version_policy() call #655

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

JSUYA
Copy link
Member

@JSUYA JSUYA commented Jan 12, 2024

If EWK, the web engine of webview flutter, has an upgrade as a UWE feature,
ewk_set_version_policy(1) must be called before set arguments.

+) Add missing ewk_shutdown().

@JSUYA JSUYA changed the title [webview_flutter] Add ewk_set_version_policy() call [do_not_merge][webview_flutter] Add ewk_set_version_policy() call Jan 18, 2024
@JSUYA JSUYA changed the title [do_not_merge][webview_flutter] Add ewk_set_version_policy() call [webview_flutter] Add ewk_set_version_policy() call Jan 22, 2024
If EWK, the web engine of webview flutter, has an upgrade as a UWE feature,
`ewk_set_version_policy(1)` must be called before set arguments.

+ Add missing ewk_shutdown().
@JSUYA
Copy link
Member Author

JSUYA commented Jan 22, 2024

Hi @swift-kim Could you please review this?

Copy link
Member

@swift-kim swift-kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JSUYA JSUYA merged commit f193d24 into flutter-tizen:master Jan 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants