[webview_flutter] Add ewk_set_version_policy() call

If EWK, the web engine of webview flutter, has an upgrade as a UWE feature, `ewk_set_version_policy(1)` must be called before set arguments. + Add missing ewk_shutdown().
flutter-tizen · Jan 22, 2024 · b1e60f9 · b1e60f9
1 parent bc1cc63
commit b1e60f9
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 3 deletions.
diff --git a/packages/webview_flutter/CHANGELOG.md b/packages/webview_flutter/CHANGELOG.md
@@ -1,3 +1,7 @@
+## NEXT
+
+* Add ewk_set_version_policy() call.
+
 ## 0.9.0
 
 * Update webivew_flutter to 4.4.2.

diff --git a/packages/webview_flutter/tizen/src/ewk_internal_api_binding.cc b/packages/webview_flutter/tizen/src/ewk_internal_api_binding.cc
@@ -42,6 +42,9 @@ bool EwkInternalApiBinding::Initialize() {
   main.SetArguments = reinterpret_cast<EwkSetArgumentsFnPtr>(
       dlsym(handle_, "ewk_set_arguments"));
 
+  main.SetVersionPolicy = reinterpret_cast<EwkSetVersionPolicyFnPtr>(
+      dlsym(handle_, "ewk_set_version_policy"));
+
   // ewk_settings
   settings.ImePanelEnabledSet =
       reinterpret_cast<EwkSettingsImePanelEnabledSetFnPtr>(
@@ -60,7 +63,8 @@ bool EwkInternalApiBinding::Initialize() {
   return view.SetBackgroundColor && view.FeedTouchEvent && view.SendKeyEvent &&
          view.OffscreenRenderingEnabledSet && view.ImeWindowSet &&
          view.KeyEventsEnabledSet && view.SupportVideoHoleSet &&
-         main.SetArguments && settings.ImePanelEnabledSet &&
-         console_message.LevelGet && console_message.TextGet &&
-         console_message.LineGet && console_message.SourceGet;
+         main.SetArguments && main.SetVersionPolicy &&
+         settings.ImePanelEnabledSet && console_message.LevelGet &&
+         console_message.TextGet && console_message.LineGet &&
+         console_message.SourceGet;
 }
diff --git a/packages/webview_flutter/tizen/src/ewk_internal_api_binding.h b/packages/webview_flutter/tizen/src/ewk_internal_api_binding.h
@@ -53,9 +53,11 @@ typedef struct {
 } EwkViewProcTable;
 
 typedef void (*EwkSetArgumentsFnPtr)(int argc, char** argv);
+typedef int (*EwkSetVersionPolicyFnPtr)(int preference);
 
 typedef struct {
   EwkSetArgumentsFnPtr SetArguments = nullptr;
+  EwkSetVersionPolicyFnPtr SetVersionPolicy = nullptr;
 } EwkMainProcTable;
 
 typedef struct Ewk_Settings Ewk_Settings;

diff --git a/packages/webview_flutter/tizen/src/webview.cc b/packages/webview_flutter/tizen/src/webview.cc
@@ -196,6 +196,8 @@ void WebView::Dispose() {
                                    &WebView::OnUrlChange);
     evas_object_del(webview_instance_);
   }
+
+  ewk_shutdown();
 }
 
 void WebView::Offset(double left, double top) {
@@ -286,6 +288,8 @@ void WebView::SetDirection(int direction) {
 }
 
 void WebView::InitWebView() {
+  EwkInternalApiBinding::GetInstance().main.SetVersionPolicy(1);
+
   char* chromium_argv[] = {
       const_cast<char*>("--disable-pinch"),
       const_cast<char*>("--js-flags=--expose-gc"),