Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite Button to Typescript #2984

Merged
merged 12 commits into from
Aug 22, 2021
Merged

Rewrite Button to Typescript #2984

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3d10902
Rename Button file
davwheat Jul 20, 2021
b9b4548
Convert to TS
davwheat Jul 20, 2021
fb05d46
Add debug warning helper
davwheat Jul 20, 2021
2fbf780
Simplify button content template
davwheat Jul 20, 2021
935d5a8
Rewrite Button component
davwheat Jul 20, 2021
ba68401
Update to work with new Button component
davwheat Jul 20, 2021
7f6f4b8
Update warning
davwheat Jul 21, 2021
1ba1aec
Fire warning in `oncreate`
davwheat Aug 9, 2021
32fa4f6
Format
davwheat Aug 9, 2021
15cda91
Make Button have extensible Attributes type via generics
davwheat Aug 20, 2021
47557b3
Update args type
davwheat Aug 20, 2021
048bab6
Update js/src/common/components/Button.tsx
davwheat Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion js/src/common/components/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ export interface IButtonAttrs extends ComponentAttrs {
* be used to represent any generic clickable control, like a menu item. Common
* styles can be applied by providing `className="Button"` to the Button component.
*/
export default class Button extends Component<IButtonAttrs> {
export default class Button<CustomAttrs extends Record<string, unknown> = {}> extends Component<IButtonAttrs & CustomAttrs> {
davwheat marked this conversation as resolved.
Show resolved Hide resolved
view(vnode: Mithril.Vnode<IButtonAttrs, never>) {
let { type, title, 'aria-label': ariaLabel, icon: iconName, disabled, loading, className, class: _class, ...attrs } = this.attrs;

Expand Down