Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite Button to Typescript #2984

Merged
merged 12 commits into from
Aug 22, 2021
Merged

Rewrite Button to Typescript #2984

merged 12 commits into from
Aug 22, 2021

Commits on Jul 30, 2021

  1. Rename Button file

    @davwheat
    davwheat committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    3d10902 View commit details
    Browse the repository at this point in the history

  2. Convert to TS

    @davwheat
    davwheat committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    b9b4548 View commit details
    Browse the repository at this point in the history

  3. Add debug warning helper 

    Fires `console.warn`, but only when the forum is in debug mode. Can help to inform extension developers of possible issues with their JS code.
    @davwheat
    davwheat committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    fb05d46 View commit details
    Browse the repository at this point in the history

  4. Simplify button content template

    @davwheat
    davwheat committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    2fbf780 View commit details
    Browse the repository at this point in the history

  5. Rewrite Button component 

    - Prefer `aria-label` over `title`
- Don't duplicate button content to `title` attribute
- Warn in debug mode if button has no accessible content
- Use modern JS/TS syntax (`||=`, spread, etc)
    @davwheat
    davwheat committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    935d5a8 View commit details
    Browse the repository at this point in the history

  6. Update to work with new Button component

    @davwheat
    davwheat committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    ba68401 View commit details
    Browse the repository at this point in the history

  7. Update warning 

    Co-authored-by: Matt Kilgore <[email protected]>
    @davwheat @tankerkiller125
    davwheat and tankerkiller125 committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    7f6f4b8 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2021

  1. Fire warning in oncreate

    @davwheat
    davwheat authored Aug 9, 2021
    Configuration menu
    Copy the full SHA
    1ba1aec View commit details
    Browse the repository at this point in the history

  2. Format

    @davwheat
    davwheat committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    32fa4f6 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2021

  1. Make Button have extensible Attributes type via generics

    @davwheat
    davwheat authored Aug 20, 2021
    Configuration menu
    Copy the full SHA
    15cda91 View commit details
    Browse the repository at this point in the history

  2. Update args type

    @davwheat
    davwheat authored Aug 20, 2021
    Configuration menu
    Copy the full SHA
    47557b3 View commit details
    Browse the repository at this point in the history

  3. Update js/src/common/components/Button.tsx

    @davwheat
    davwheat authored Aug 20, 2021
    Configuration menu
    Copy the full SHA
    048bab6 View commit details
    Browse the repository at this point in the history