Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

"README.asciidoc" updates - join 3 alien "pull requests" #16

Closed
wants to merge 8 commits into from

Conversation

alexei-31
Copy link

This branch join three other pull requests from old @felipec repository and from new. This branch is prepared to merge without conflicts (special to keep your time):

You just need to do just the merger, as a result must change only one file README.asciidoc, effect you can see in commit 144bf11. Other changes have been merged you in aa38707, but without reference to previous authors, however not influence the outcome. Therefore, this is the minimum change is perfectly safe.

As a result, three different author (@jboning, @johnjohndoe, @tboegi) may be gladdened the successful inclusion of theirs changes to the common cause. They tried do work, waiting for a long time and this deserve little reward. It will be possible to assert with confidence that the project is progressing.

I am worried about the fate of the project, and I care about its future. The participation of many authors and the interception of their "pull requests" in the "fork" will improve your reputation. If the project will develop, one day I'll wait for the solution of the problem #8. :-)

As well as to be a beautiful picture in the network graph.

jboning and others added 8 commits July 10, 2014 13:04
Github seems to have moved to hosting files at githubusercontent.com.
Many Linux systems ship with wget, but not with curl.
Mac OS X 10.9 ships with curl, but not with wget.
On older versions the user needs to install either wget or curl.

Mention both wget and curl.
Change the download URL for git-remote-hg to this very repository,
which supports hg 3.2
This reverts commit 748cb1d.

# Conflicts:
#	README.asciidoc
@fingolfin
Copy link
Owner

@alexei-31 Thank you for your efforts, however, I am not going to merge this PR.

First off, I do not want to tell people to use pip install --user mercurial -- those who know what they are doing do not need to be told, those who don't shouldn't be told this without further qualification. E.g. an Ubuntu user is probably better of installing the mercurial package. And people who are not able to figure how to "install mercurial" (as told by the README) really should not touch git-remote-hg in the first place.

Secondly, attribution: Yes, I integrated some README changes originally proposed by @jboning, @johnjohndoe, @tboegi albeit in modified form. I guess I should have added an "inspired-by" or so sign-off, for full credit, but frankly I didn't think it necessary for relatively trivial (though of course very helpful) changes. Anyway: @jboning, @johnjohndoe, @tboegi -- if any of you feels slighted by this, I apologize. We could add a THANKS or AUTHORS file to collect credits like that, if you like.

In the end, all this PR does is clutter the history with no benefit gained for users.

@fingolfin fingolfin closed this Dec 7, 2015
@alexei-31
Copy link
Author

It is very sad, of course, but it is your right. But hardly anyone will do a special pull request for this.

As I understand it, in the development you do not like to make other people's changes, but the soul is given to the project.

In my opinion, the merger does not harm the project, but only emphasize its importance. But you are a supporter of linear history, this also has its own charm.

I studied all the forks and moved to "pull requets" all significant works at your discretion. Now I have no illusions, that in history there will be many different developers. Perhaps this is not necessary.

I wish you good luck and project!

@alexei-31 alexei-31 deleted the readme-all-updates branch December 7, 2015 14:44
@alexei-31 alexei-31 restored the readme-all-updates branch December 7, 2015 17:00
@alexei-31 alexei-31 deleted the readme-all-updates branch December 7, 2015 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants