Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

"Branch name doesn't conform to GIT standards" (moving felipec:#7) #18

Closed
wants to merge 1 commit into from

Conversation

alexei-31
Copy link

This request is transferred from the old project, and may be more relevant here.
See the discussion in the old issue felipec:#7

git-remote-hg: Fix . at end of ref

Any Mercurial tag/branch/bookmark that ended with a period would be
rejected by fast-import. The repository could be cloned, but any
further fetch would fail.

Use a similar trick to the space handling, but only when the period is
at the end of the ref.

Probably need a more general solution to this problem.

Signed-off-by: Brian Gernhardt [email protected]

Any Mercurial tag/branch/bookmark that ended with a period would be
rejected by fast-import.  The repository could be cloned, but any
further fetch would fail.

Use a similar trick to the space handling, but only when the period is
at the end of the ref.

Probably need a more general solution to this problem.

Signed-off-by: Brian Gernhardt <[email protected]>
@alexei-31
Copy link
Author

I can combine this request (#18) with #19 in the one "pull request" (as is done in #16) for your comfort and beautiful history, if both of them are approved.

@fingolfin
Copy link
Owner

@alexei-31 You can write felipec/git#7 to reference to issues in other repositories, like this: felipec/git#7

@alexei-31
Copy link
Author

As I understand, git-remote-hg is not use felipec/git in work.
Help the little-known fork of git by @felipec is useless here.
All use the official git repository to install git utility. Many installed a binary package, and not the source code.
Maybe something I do not understand, but can not help the fork fix crash of this program?

@fingolfin
Copy link
Owner

@alexei-31 I am once again not sure what you are talking about, at all :-(. Does it refer to my previous comment? If so: My previous comment just was meant to tell you that instead of writing felipec:[#7](https://github.com/felipec/git-remote-hg/pull/7) you can write felipec/git#7 :-)

@alexei-31
Copy link
Author

Here I offer 0669be9 as better solution of the issue, that has started @andyparkins in original request.
These are different versions of code, your comment is written to my comment about another solution.

New solution of @Benabik make checks only at the end strings, as I understand the code.

@fingolfin
Copy link
Owner

I was not talking about code. I was not talking about this PR.

I only tried to explain that you can write USER/REPO#NUM instead of [#NUM](https://github.com/USER/REPO/pull/NUM)

@alexei-31
Copy link
Author

Thank you, this way is easier.

Sorry did not immediately understand that we are about the design, not the code.

Is there a need to fix old messages to successfully complete PR?

@jan-hudec
Copy link

I've just encountered:

fatal: Branch name doesn't conform to GIT standards: refs/hg/upstream/tags/gmp-3_0___**FUNKY**

(in hg::https://gmplib.org/repo/gmp/)

@fingolfin fingolfin closed this Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants