feat: replace redis keys call with scan #106
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've started seeing entries in the Redis slowlog related to retrieving keys for
kong_acme:renew_config
. Here is a sample:This PR replaces the usage of
keys
withscan
. Per Redis documentationscan
is preferred overkeys
in production environments.A new config option
scan_count
is introduced to configure how many keys should be returned each call. It defaults to10
which is the Redis default. Note that Redis does not guarantee that it will obey this value.An additional test was also added with 50 keys that tests multiple scan calls.