feat(acme): add scan_count to redis storage schema #11532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! Let's add a test https://github.com/Kong/kong/blob/master/spec/03-plugins/29-acme/05-redis_storage_spec.lua |
kikito
added
the
pending author feedback
github-actions
bot
added
the
author/community
* bump lua-resty-acme plugin to 0.12.0 * expose scan_count in redis storage schema to configure the number of keys returned in redis scan calls
szesch
force-pushed
the
feat/acme-redis-scan-count
branch
from
4d5b1da to
6a2cf8d
Compare
|
@fffonion updated with a unit test and change log file |
fffonion
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SRE has started seeing entries in the Redis slowlog related to retrieving keys for
kong_acme:renew_config. lua-resty-acme was recently changed to use Redisscaninstead ofkeysfor performance reasons. See the lua-resty-acme PR for more details fffonion/lua-resty-acme#106.This PR exposes a new configuration field for Redis storage that controls how many keys are returned in a
scancall and bumps lua-resty-acme to 0.12.0.Checklist
CHANGELOG/unreleased/kongor addingskip-changeloglabel on PR if unnecessary. README.md@fffonion