Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add extra args of feast serve cli in gunicorn #4692

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions sdk/python/feast/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -896,6 +896,28 @@ def init_command(project_directory, minimal: bool, template: str):
show_default=True,
help="Number of worker",
)
@click.option(
"--threads",
"-t",
type=click.INT,
default=1,
show_default=True,
help="Number of thread"
)
@click.option(
"--max-requests",
type=click.INT,
default=0,
show_default=True,
help="The number of requests required to meet the conditions for worker process restart"
)
@click.option(
"--max-requests-jitter",
type=click.INT,
default=0,
show_default=True,
help="A value to update `max-requests` randomly for each process to prevent multiple worker processes from restarting simultaneously",
)
@click.option(
"--keep-alive-timeout",
type=click.INT,
Expand Down Expand Up @@ -926,6 +948,9 @@ def serve_command(
type_: str,
no_access_log: bool,
workers: int,
threads: int,
max_requests: int,
max_requests_jitter: int,
metrics: bool,
keep_alive_timeout: int,
registry_ttl_sec: int = 5,
Expand All @@ -939,6 +964,9 @@ def serve_command(
type_=type_,
no_access_log=no_access_log,
workers=workers,
threads=threads,
max_requests=max_requests,
max_requests_jitter=max_requests_jitter,
metrics=metrics,
keep_alive_timeout=keep_alive_timeout,
registry_ttl_sec=registry_ttl_sec,
Expand Down
6 changes: 6 additions & 0 deletions sdk/python/feast/feature_server.py
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,9 @@ def start_server(
port: int,
no_access_log: bool,
workers: int,
threads: int,
max_requests: int,
max_requests_jitter: int,
keep_alive_timeout: int,
registry_ttl_sec: int,
metrics: bool,
Expand Down Expand Up @@ -369,6 +372,9 @@ def start_server(
bind=f"{host}:{port}",
accesslog=None if no_access_log else "-",
workers=workers,
threads=threads,
max_requests=max_requests,
max_requests_jitter=max_requests_jitter,
keepalive=keep_alive_timeout,
registry_ttl_sec=registry_ttl_sec,
).run()
Expand Down
6 changes: 6 additions & 0 deletions sdk/python/feast/feature_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -1894,6 +1894,9 @@ def serve(
type_: str = "http",
no_access_log: bool = True,
workers: int = 1,
threads: int = 1,
max_requests: int = 0,
max_requests_jitter: int = 0,
metrics: bool = False,
keep_alive_timeout: int = 30,
registry_ttl_sec: int = 2,
Expand All @@ -1911,6 +1914,9 @@ def serve(
port=port,
no_access_log=no_access_log,
workers=workers,
threads=threads,
max_requests=max_requests,
max_requests_jitter=max_requests_jitter,
metrics=metrics,
keep_alive_timeout=keep_alive_timeout,
registry_ttl_sec=registry_ttl_sec,
Expand Down