Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add extra args of feast serve cli in gunicorn #4692

Closed

Conversation

young-hun-jo
Copy link

What this PR does / why we need it:

Python feast feature server is using FastAPI and gunicorn and it is run by command feast serve. When I search extra optons in gunicorn of feast serve, only few options can be used(for example, keepalive, workers). So I add extra arguments of other gunicorn options. These are threads, max_requests, max_requests_jitter. I

I would run Python feast feature server on EKS environments on production. In this production environments, so many requests is come to feast feature server but only workers options is not enough to run feature server on production.

Especially, I add these arguments for python memory leaking because of automated python's own garbage collector. Combination of max_requests and max_requests_jitter is appropriate for preventing circumstances that multi-worker process is simultaneously restarted over max_requests.

If these options is added, python feast feature server on production is running when so many requests is come to the server. I looking forward to reviewing yours. thanks.

Which issue(s) this PR fixes:

Misc

@young-hun-jo young-hun-jo requested a review from a team as a code owner October 25, 2024 14:20
@young-hun-jo
Copy link
Author

young-hun-jo commented Oct 25, 2024

a commit username mistakenly done by my other account. so I close it and I will make PR(#4693) again

@young-hun-jo young-hun-jo deleted the feat/gunicorn/extra-config branch October 25, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants