feat: add extra args of feast serve cli in gunicorn #4692
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Python feast feature server is using FastAPI and gunicorn and it is run by command
feast serve
. When I search extra optons in gunicorn offeast serve
, only few options can be used(for example,keepalive
,workers
). So I add extra arguments of other gunicorn options. These arethreads
,max_requests
,max_requests_jitter
. II would run Python feast feature server on EKS environments on production. In this production environments, so many requests is come to feast feature server but only
workers
options is not enough to run feature server on production.Especially, I add these arguments for python memory leaking because of automated python's own garbage collector. Combination of
max_requests
andmax_requests_jitter
is appropriate for preventing circumstances that multi-worker process is simultaneously restarted overmax_requests
.If these options is added, python feast feature server on production is running when so many requests is come to the server. I looking forward to reviewing yours. thanks.
Which issue(s) this PR fixes:
Misc