chore: Enable one future react-router-dom flag

react-router-dom was writing warning messages in the console about
upcoming features in v7 and suggested opting in early. I tried turning
them on, but couldn't get custom tabs navigation working properly with
v7_relativeSplatPath enabled, so decided to keep it off for now. (Plus
it might also break something in consuming apps.)

v7_startTransition only needed an update in one place in a test where we
need to await for the UI to update, so kept it on. It also shouldn't
require any changes in consuming application code, though possibly
something in tests like we needed here.

Related docs:

- https://reactrouter.com/en/6.28.0/upgrading/future#v7_relativesplatpath

- https://reactrouter.com/en/6.28.0/upgrading/future#v7_starttransition

Signed-off-by: Harri Lehtola <[email protected]>

ui/src/FeastUI.tsx

@@ -17,7 +17,8 @@ const FeastUI = ({ reactQueryClient, feastUIConfigs }: FeastUIProps) => {
   const queryClient = reactQueryClient || defaultQueryClient;
 
   return (
-    <BrowserRouter>
+    // Disable v7_relativeSplatPath: custom tab routes don't currently work with it
+    <BrowserRouter future={{ v7_relativeSplatPath: false, v7_startTransition: true }}>
       <QueryClientProvider client={queryClient}>
         <QueryParamProvider adapter={ReactRouter6Adapter}>
           <FeastUISansProviders feastUIConfigs={feastUIConfigs} />

ui/src/components/ProjectSelector.test.tsx

@@ -40,7 +40,7 @@ test("in a full App render, it shows the right initial project", async () => {
     name: "Top Level",
   });
 
-  within(topLevelNavigation).getByDisplayValue("Credit Score Project");
+  await within(topLevelNavigation).findByDisplayValue("Credit Score Project");
 
   expect(options.length).toBe(1);
 

ui/src/test-utils.tsx

@@ -14,7 +14,11 @@ const queryClient = new QueryClient();
 const AllTheProviders = ({ children }: ProvidersProps) => {
   return (
     <QueryClientProvider client={queryClient}>
-      <Router initialEntries={["/"]}>
+      <Router
+        // Disable v7_relativeSplatPath: custom tab routes don't currently work with it
+        future={{ v7_relativeSplatPath: false, v7_startTransition: true }}
+        initialEntries={["/"]}
+      >
         <QueryParamProvider adapter={ReactRouter6Adapter}>
           {children}
         </QueryParamProvider>