Skip to content

Commit

Permalink
chore: Upgrade use-query-params to latest 2.2.1
Browse files Browse the repository at this point in the history
Updating query params when filtering table views somehow stopped working
after upgrading react-router-dom, upgrading use-query-params too fixes
that.

Signed-off-by: Harri Lehtola <[email protected]>
  • Loading branch information
peruukki committed Nov 16, 2024
1 parent da15f8a commit 27d52a9
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 12 deletions.
2 changes: 1 addition & 1 deletion ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"react-query": "^3.39.3",
"react-router-dom": "^6.28.0",
"tslib": "^2.3.1",
"use-query-params": "^1.2.3",
"use-query-params": "^2.2.1",
"zod": "^3.11.6"
},
"scripts": {
Expand Down
3 changes: 2 additions & 1 deletion ui/src/FeastUI.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import React from "react";
import { BrowserRouter } from "react-router-dom";
import { QueryClient, QueryClientProvider } from "react-query";
import { QueryParamProvider } from "use-query-params";
import { ReactRouter6Adapter } from 'use-query-params/adapters/react-router-6';
import FeastUISansProviders, { FeastUIConfigs } from "./FeastUISansProviders";

interface FeastUIProps {
Expand All @@ -18,7 +19,7 @@ const FeastUI = ({ reactQueryClient, feastUIConfigs }: FeastUIProps) => {
return (
<BrowserRouter>
<QueryClientProvider client={queryClient}>
<QueryParamProvider>
<QueryParamProvider adapter={ReactRouter6Adapter}>
<FeastUISansProviders feastUIConfigs={feastUIConfigs} />
</QueryParamProvider>
</QueryClientProvider>
Expand Down
3 changes: 2 additions & 1 deletion ui/src/test-utils.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React from "react";
import { render, RenderOptions } from "@testing-library/react";
import { QueryClient, QueryClientProvider } from "react-query";
import { QueryParamProvider } from "use-query-params";
import { ReactRouter6Adapter } from 'use-query-params/adapters/react-router-6';
import { MemoryRouter as Router } from "react-router-dom";

interface ProvidersProps {
Expand All @@ -14,7 +15,7 @@ const AllTheProviders = ({ children }: ProvidersProps) => {
return (
<QueryClientProvider client={queryClient}>
<Router initialEntries={["/"]}>
<QueryParamProvider>
<QueryParamProvider adapter={ReactRouter6Adapter}>
{children}
</QueryParamProvider>
</Router>
Expand Down
18 changes: 9 additions & 9 deletions ui/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -10586,10 +10586,10 @@ serialize-javascript@^6.0.0, serialize-javascript@^6.0.1:
dependencies:
randombytes "^2.1.0"

serialize-query-params@^1.3.5:
version "1.3.6"
resolved "https://registry.yarnpkg.com/serialize-query-params/-/serialize-query-params-1.3.6.tgz#5dd5225db85ce747fe6fbc4897628504faafec6d"
integrity sha512-VlH7sfWNyPVZClPkRacopn6sn5uQMXBsjPVz1+pBHX895VpcYVznfJtZ49e6jymcrz+l/vowkepCZn/7xEAEdw==
serialize-query-params@^2.0.2:
version "2.0.2"
resolved "https://registry.yarnpkg.com/serialize-query-params/-/serialize-query-params-2.0.2.tgz#598a3fb9e13f4ea1c1992fbd20231aa16b31db81"
integrity sha512-1chMo1dST4pFA9RDXAtF0Rbjaut4is7bzFbI1Z26IuMub68pNCILku85aYmeFhvnY//BXUPUhoRMjYcsT93J/Q==

serve-index@^1.9.1:
version "1.9.1"
Expand Down Expand Up @@ -11707,12 +11707,12 @@ use-memo-one@^1.1.3:
resolved "https://registry.yarnpkg.com/use-memo-one/-/use-memo-one-1.1.3.tgz#2fd2e43a2169eabc7496960ace8c79efef975e99"
integrity sha512-g66/K7ZQGYrI6dy8GLpVcMsBp4s17xNkYJVSMvTEevGy3nDxHOfE6z8BVE22+5G5x7t3+bhzrlTDB7ObrEE0cQ==

use-query-params@^1.2.3:
version "1.2.3"
resolved "https://registry.yarnpkg.com/use-query-params/-/use-query-params-1.2.3.tgz#306c31a0cbc714e8a3b4bd7e91a6a9aaccaa5e22"
integrity sha512-cdG0tgbzK+FzsV6DAt2CN8Saa3WpRnze7uC4Rdh7l15epSFq7egmcB/zuREvPNwO5Yk80nUpDZpiyHsoq50d8w==
use-query-params@^2.2.1:
version "2.2.1"
resolved "https://registry.yarnpkg.com/use-query-params/-/use-query-params-2.2.1.tgz#c558ab70706f319112fbccabf6867b9f904e947d"
integrity sha512-i6alcyLB8w9i3ZK3caNftdb+UnbfBRNPDnc89CNQWkGRmDrm/gfydHvMBfVsQJRq3NoHOM2dt/ceBWG2397v1Q==
dependencies:
serialize-query-params "^1.3.5"
serialize-query-params "^2.0.2"

use-sidecar@^1.1.2:
version "1.1.2"
Expand Down

0 comments on commit 27d52a9

Please sign in to comment.