Dump crash files into test failure messages #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this feature be hidden behind a flag (i.e. trainer arg to enable this on cli)? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
benasher44
force-pushed
the
basher/dump-crashes
branch
from
102475d to
0e181f1
Compare
|
Updated with master, but I still have a bit of testing left to do |
|
With the ability to open xcresult bundles in Xcode 11, this PR isn't as useful. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #26. It will look for crash "activities", extract the related crash files, and dump them into the failure messages. The output looks kind of funny (i.e. the huge failure message), but I think this should work?
TODO: