Add option to opt into crash trace collection

lib/trainer/options.rb

@@ -33,7 +33,12 @@ def self.available_options
                                      env_name: "TRAINER_FAIL_BUILD",
                                      description: "Should this step stop the build if the tests fail? Set this to false if you're handling this with a test reporter",
                                      is_string: false,
-                                     default_value: true)
+                                     default_value: true),
+        FastlaneCore::ConfigItem.new(key: :include_crash_trace,
+                                     env_name: "TRAINER_INCLUDE_CRASH_TRACE",
+                                     description: "If there is a crash associated with a test failure, the contents of the .crash file will be included in the failure text",
+                                     is_string: false,
+                                     default_value: false)
       ]
     end
   end

lib/trainer/test_parser.rb

@@ -8,6 +8,8 @@ class TestParser
 
     attr_accessor :plist_dir
 
+    attr_accessor :include_crash_trace
+
     # Returns a hash with the path being the key, and the value
     # defining if the tests were successful
     def self.auto_convert(config)
@@ -39,7 +41,7 @@ def self.auto_convert(config)
           to_path = path.gsub(".plist", config[:extension])
         end
 
-        tp = Trainer::TestParser.new(path)
+        tp = Trainer::TestParser.new(path, config[:include_crash_trace])
         File.write(to_path, tp.to_junit)
         puts "Successfully generated '#{to_path}'"
 
@@ -48,9 +50,10 @@ def self.auto_convert(config)
       return_hash
     end
 
-    def initialize(path)
+    def initialize(path, include_crash_trace = false)
       path = File.expand_path(path)
       self.plist_dir = File.dirname path
+      self.include_crash_trace = include_crash_trace
       UI.user_error!("File not found at path '#{path}'") unless File.exist?(path)
 
       self.file_content = File.read(path)
@@ -138,11 +141,13 @@ def parse_content
                   failure_message: "#{current_failure['Message']} (#{current_failure['FileName']}:#{current_failure['LineNumber']})"
                 }
               end
-              activity_summaries = current_test['ActivitySummaries'] || []
-              crash_attachment_file = activity_summaries.map { |a| a['DiagnosticReportFileName'] }.compact.find { |f| f.end_with? '.crash' }
-              unless crash_attachment_file.nil?
-                crash_attachment_path = File.join(self.plist_dir, 'Attachments', crash_attachment_file)
-                current_row[:failures].first[:failure_trace] = File.open(crash_attachment_path, &:read)
+              if self.include_crash_trace
+                activity_summaries = current_test['ActivitySummaries'] || []
+                crash_attachment_file = activity_summaries.map { |a| a['DiagnosticReportFileName'] }.compact.find { |f| f.end_with? '.crash' }
+                unless crash_attachment_file.nil?
+                  crash_attachment_path = File.join(self.plist_dir, 'Attachments', crash_attachment_file)
+                  current_row[:failures].first[:failure_trace] = File.open(crash_attachment_path, &:read)
+                end
               end
             end
             current_row

spec/junit_generator_spec.rb

@@ -13,7 +13,7 @@
     end
 
     it "includes .crash test attachments" do
-      tp = Trainer::TestParser.new("spec/fixtures/Test-ShapeSwift.xcresult/TestSummaries.plist")
+      tp = Trainer::TestParser.new("spec/fixtures/Test-ShapeSwift.xcresult/TestSummaries.plist", true)
       junit = File.read("spec/fixtures/Test-ShapeSwift.xcresult/TestSummaries.xml")
       expect(tp.to_junit).to eq(junit)
     end