Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hlx urls to aem #78

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Change hlx urls to aem #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e793ae0
Change hlx urls to aem
tonyklapatch Nov 6, 2024
f363440
Update aem.js, fix breaking changes in scripts.js
tonyklapatch Nov 7, 2024
68a1aaa
Fix sidebar block after aem.js update
tonyklapatch Nov 7, 2024
d5f13ad
Fix linting issue
tonyklapatch Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ Please always provide the [GitHub issue(s)](../issues) your PR is for, as well a
Fix #<gh-issue-id>

Test URLs:
- Before: https://main--best-cigars-guide--famous-smoke.hlx.live/
- After: https://<branch>--best-cigars-guide--famous-smoke.hlx.live/
- Before: https://main--best-cigars-guide--famous-smoke.aem.live/
- After: https://<branch>--best-cigars-guide--famous-smoke.aem.live/
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ Find the best recommended Cigars by year, occasion, shape, size, country, food p
- https://www.famous-smoke.com/best-cigars-guide/

## AEM Preview Environments
- Preview: https://main--best-cigars-guide--famous-smoke.hlx.page/best-cigars-guide
- Live: https://main--best-cigars-guide--famous-smoke.hlx.live/best-cigars-guide
- Preview: https://main--best-cigars-guide--famous-smoke.aem.page/best-cigars-guide
- Live: https://main--best-cigars-guide--famous-smoke.aem.live/best-cigars-guide

## Installation

Expand All @@ -27,4 +27,4 @@ npm run lint
1. Install the [AEM CLI](https://github.com/adobe/helix-cli): `npm install -g @adobe/aem-cli`
1. Start AEM Proxy: `aem up` (opens your browser at `http://localhost:3000`)
1. Open the `best-cigars-guide` directory in your favorite IDE and start coding :)
1. Once you are are ready to push your changes, simply use Git to add, commit, and push and your code to your preview `https://<branch>--<repo>--<owner>.hlx.page/` and production `https://<branch>--<repo>--<owner>.hlx.live/` sites.
1. Once you are are ready to push your changes, simply use Git to add, commit, and push and your code to your preview `https://<branch>--<repo>--<owner>.aem.page/` and production `https://<branch>--<repo>--<owner>.aem.live/` sites.
4 changes: 2 additions & 2 deletions best-cigars-guide/blocks/fragment/fragment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
} from '../../scripts/scripts.js';

import {
loadBlocks,
loadSections,
} from '../../scripts/aem.js';

/**
Expand All @@ -34,7 +34,7 @@ export async function loadFragment(path) {
resetAttributeBase('source', 'srcset');

decorateMain(main);
await loadBlocks(main);
await loadSections(main);
return main;
}
}
Expand Down
Loading