Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change hlx urls to aem #78

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Change hlx urls to aem #78

merged 4 commits into from
Nov 13, 2024

Conversation

tonyklapatch
Copy link
Contributor

@tonyklapatch tonyklapatch commented Nov 6, 2024 •
edited
Loading

Change hlx url references to aem, I didn't modify the import files since they should no longer be needed to run again.

Updates aem.js to match the latest in the boilerplate: https://github.com/adobe/aem-boilerplate/blob/main/scripts/aem.js

Fix #77

Test URLs:

@tonyklapatch tonyklapatch linked an issue Nov 6, 2024 that may be closed by this pull request
Change hlx.live URLs to aem.live #77
Closed
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 6, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 6, 2024 •
edited
Loading

Page Scores Audits Google
📱 /best-cigars-guide PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /best-cigars-guide PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

famoussmoke
famoussmoke approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@famoussmoke famoussmoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, site still works.

@famoussmoke famoussmoke merged commit 5b08b00 into main Nov 13, 2024
2 checks passed
@famoussmoke famoussmoke deleted the 77-aemlive-urls branch November 13, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@famoussmoke famoussmoke famoussmoke approved these changes

@codecodeio codecodeio Awaiting requested review from codecodeio

@bdeffleyfamous bdeffleyfamous Awaiting requested review from bdeffleyfamous

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change hlx.live URLs to aem.live
2 participants
@tonyklapatch @famoussmoke