Update ktfmt plugin for IntelliJ IDEA #420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
greyhairredbear
force-pushed
the
feature/update-idea-plugin
branch
from
c250d98
to
188221d
Compare
|
I believe this will also fix #388 |
- gradle wrapper - intellij gradle plugin
greyhairredbear
force-pushed
the
feature/update-idea-plugin
branch
from
188221d
to
4a447c3
Compare
|
Note for reviewers: The |
greyhairredbear
changed the title
|
@cgrushko @strulovich Seems running the workflows on this PR need approval from a maintainer - would it be possible to run the workflows? Other than that, is there a way to get feedback on the changes? Could I help in any way? |
|
@hick209 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Sorry the super long delay here @greyhairredbear. I went on paternity leave in September (son born on 22 of Sept) and once I was back early this year there were many things pilled up that took me a while to go through. I'm importing this internally for review and we should have some feedback for you this week. |
Hi, no need for excuses here. Congrats on your son, being a father of three, I completely understand the priorities here :) Happy about any feedback or change requests |
hick209
reviewed
Mar 25, 2024
ktfmt_idea_plugin/src/main/java/com/facebook/ktfmt/intellij/KtfmtFormattingService.java
Show resolved
Hide resolved
hick209
requested changes
Mar 26, 2024
hick209
approved these changes
Mar 27, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
Summary: Changelog: * Migrated to Google Java Format 1.22.0 (#440 and #452) * Added support for RangUntil (`..<`) operator (#433) * Trailing space issue on lambda blocks (#426) * Fix empty enum parse error (#425) * Preserving empty enums semicolons (#434) * Always use UTF8 (#437) * IntelliJI DEA plugin update (#420) * Managing trailing commas in enums (#449) * Badges on README (#446 and #453) * Emit parsing error for calls with multiple trailing lambdas (#457) * Removed duplicated line in editorconfig file (#456) Reviewed By: cortinico Differential Revision: D56467599 fbshipit-source-id: 10e90a34118267e36db80940f6a4e43aef89fbd3
github-merge-queue bot
referenced
this pull request
in slackhq/foundry
Apr 27, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.facebook:ktfmt](https://togithub.com/facebookincubator/ktfmt) | dependencies | minor | `0.47` -> `0.49` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>facebookincubator/ktfmt (com.facebook:ktfmt)</summary> ### [`v0.49`](https://togithub.com/facebook/ktfmt/releases/tag/v0.49) #### Changelog - Stop emitting multiple trailing commas in enum entry lists with multiline items ([https://github.com/facebook/ktfmt/pull/458](https://togithub.com/facebook/ktfmt/pull/458)) – [@​nreid260](https://togithub.com/nreid260) **Full Changelog**: facebook/ktfmt@v0.48...v0.49 ### [`v0.48`](https://togithub.com/facebook/ktfmt/releases/tag/v0.48): 0.48 Changelog: - Migrated to Google Java Format 1.22.0 ([https://github.com/facebook/ktfmt/pull/440](https://togithub.com/facebook/ktfmt/pull/440), [https://github.com/facebook/ktfmt/pull/452](https://togithub.com/facebook/ktfmt/pull/452)) – [@​j-bahr](https://togithub.com/j-bahr), [@​nreid260](https://togithub.com/nreid260) - Added support for RangUntil (`..<`) operator ([https://github.com/facebook/ktfmt/pull/433](https://togithub.com/facebook/ktfmt/pull/433)) – [@​ArchdukeTim](https://togithub.com/ArchdukeTim) - Trailing space issue on lambda blocks ([https://github.com/facebook/ktfmt/pull/426](https://togithub.com/facebook/ktfmt/pull/426)) – [@​fredyw](https://togithub.com/fredyw), [@​hick209](https://togithub.com/hick209) - Fix empty enum parse error ([https://github.com/facebook/ktfmt/pull/425](https://togithub.com/facebook/ktfmt/pull/425)) – [@​fredyw](https://togithub.com/fredyw) - Preserving empty enums semicolons ([https://github.com/facebook/ktfmt/pull/434](https://togithub.com/facebook/ktfmt/pull/434)) – [@​nreid260](https://togithub.com/nreid260) - Always use UTF8 ([https://github.com/facebook/ktfmt/pull/437](https://togithub.com/facebook/ktfmt/pull/437)) – [@​nreid260](https://togithub.com/nreid260) - IntelliJI DEA plugin update ([https://github.com/facebook/ktfmt/pull/420](https://togithub.com/facebook/ktfmt/pull/420)) – [@​greyhairredbear](https://togithub.com/greyhairredbear) - Managing trailing commas in enums ([https://github.com/facebook/ktfmt/pull/449](https://togithub.com/facebook/ktfmt/pull/449)) – [@​nreid260](https://togithub.com/nreid260) - Badges on README ([https://github.com/facebook/ktfmt/pull/448](https://togithub.com/facebook/ktfmt/pull/448), [https://github.com/facebook/ktfmt/pull/453](https://togithub.com/facebook/ktfmt/pull/453)) – [@​JavierSegoviaCordoba](https://togithub.com/JavierSegoviaCordoba), [@​hick209](https://togithub.com/hick209) - Emit parsing error for calls with multiple trailing lambdas ([https://github.com/facebook/ktfmt/pull/457](https://togithub.com/facebook/ktfmt/pull/457)) – [@​nreid260](https://togithub.com/nreid260) - Removed duplicated line in editorconfig file ([https://github.com/facebook/ktfmt/pull/456](https://togithub.com/facebook/ktfmt/pull/456)) – [@​sabufung30](https://togithub.com/sabufung30) Big thanks to all the contributors! **Full Changelog**: facebook/ktfmt@v0.47...v0.48 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> --------- Co-authored-by: Zac Sweers <[email protected]>
github-merge-queue bot
referenced
this pull request
in slackhq/circuit
Apr 28, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.facebook:ktfmt](https://togithub.com/facebook/ktfmt) | dependencies | minor | `0.47` -> `0.49` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>facebook/ktfmt (com.facebook:ktfmt)</summary> ### [`v0.49`](https://togithub.com/facebook/ktfmt/releases/tag/v0.49) #### Changelog - Stop emitting multiple trailing commas in enum entry lists with multiline items ([https://github.com/facebook/ktfmt/pull/458](https://togithub.com/facebook/ktfmt/pull/458)) – [@​nreid260](https://togithub.com/nreid260) **Full Changelog**: facebook/ktfmt@v0.48...v0.49 ### [`v0.48`](https://togithub.com/facebook/ktfmt/releases/tag/v0.48): 0.48 Changelog: - Migrated to Google Java Format 1.22.0 ([https://github.com/facebook/ktfmt/pull/440](https://togithub.com/facebook/ktfmt/pull/440), [https://github.com/facebook/ktfmt/pull/452](https://togithub.com/facebook/ktfmt/pull/452)) – [@​j-bahr](https://togithub.com/j-bahr), [@​nreid260](https://togithub.com/nreid260) - Added support for RangUntil (`..<`) operator ([https://github.com/facebook/ktfmt/pull/433](https://togithub.com/facebook/ktfmt/pull/433)) – [@​ArchdukeTim](https://togithub.com/ArchdukeTim) - Trailing space issue on lambda blocks ([https://github.com/facebook/ktfmt/pull/426](https://togithub.com/facebook/ktfmt/pull/426)) – [@​fredyw](https://togithub.com/fredyw), [@​hick209](https://togithub.com/hick209) - Fix empty enum parse error ([https://github.com/facebook/ktfmt/pull/425](https://togithub.com/facebook/ktfmt/pull/425)) – [@​fredyw](https://togithub.com/fredyw) - Preserving empty enums semicolons ([https://github.com/facebook/ktfmt/pull/434](https://togithub.com/facebook/ktfmt/pull/434)) – [@​nreid260](https://togithub.com/nreid260) - Always use UTF8 ([https://github.com/facebook/ktfmt/pull/437](https://togithub.com/facebook/ktfmt/pull/437)) – [@​nreid260](https://togithub.com/nreid260) - IntelliJI DEA plugin update ([https://github.com/facebook/ktfmt/pull/420](https://togithub.com/facebook/ktfmt/pull/420)) – [@​greyhairredbear](https://togithub.com/greyhairredbear) - Managing trailing commas in enums ([https://github.com/facebook/ktfmt/pull/449](https://togithub.com/facebook/ktfmt/pull/449)) – [@​nreid260](https://togithub.com/nreid260) - Badges on README ([https://github.com/facebook/ktfmt/pull/448](https://togithub.com/facebook/ktfmt/pull/448), [https://github.com/facebook/ktfmt/pull/453](https://togithub.com/facebook/ktfmt/pull/453)) – [@​JavierSegoviaCordoba](https://togithub.com/JavierSegoviaCordoba), [@​hick209](https://togithub.com/hick209) - Emit parsing error for calls with multiple trailing lambdas ([https://github.com/facebook/ktfmt/pull/457](https://togithub.com/facebook/ktfmt/pull/457)) – [@​nreid260](https://togithub.com/nreid260) - Removed duplicated line in editorconfig file ([https://github.com/facebook/ktfmt/pull/456](https://togithub.com/facebook/ktfmt/pull/456)) – [@​sabufung30](https://togithub.com/sabufung30) Big thanks to all the contributors! **Full Changelog**: facebook/ktfmt@v0.47...v0.48 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjYuMCIsInVwZGF0ZWRJblZlciI6IjM3LjMyNi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> --------- Co-authored-by: Zac Sweers <[email protected]>
ZacSweers
referenced
this pull request
in ZacSweers/CatchUp
Apr 29, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.facebook:ktfmt](https://togithub.com/facebook/ktfmt) | `0.47` -> `0.49` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>facebook/ktfmt (com.facebook:ktfmt)</summary> ### [`v0.49`](https://togithub.com/facebook/ktfmt/releases/tag/v0.49) #### Changelog - Stop emitting multiple trailing commas in enum entry lists with multiline items ([https://github.com/facebook/ktfmt/pull/458](https://togithub.com/facebook/ktfmt/pull/458)) – [@​nreid260](https://togithub.com/nreid260) **Full Changelog**: facebook/ktfmt@v0.48...v0.49 ### [`v0.48`](https://togithub.com/facebook/ktfmt/releases/tag/v0.48): 0.48 Changelog: - Migrated to Google Java Format 1.22.0 ([https://github.com/facebook/ktfmt/pull/440](https://togithub.com/facebook/ktfmt/pull/440), [https://github.com/facebook/ktfmt/pull/452](https://togithub.com/facebook/ktfmt/pull/452)) – [@​j-bahr](https://togithub.com/j-bahr), [@​nreid260](https://togithub.com/nreid260) - Added support for RangUntil (`..<`) operator ([https://github.com/facebook/ktfmt/pull/433](https://togithub.com/facebook/ktfmt/pull/433)) – [@​ArchdukeTim](https://togithub.com/ArchdukeTim) - Trailing space issue on lambda blocks ([https://github.com/facebook/ktfmt/pull/426](https://togithub.com/facebook/ktfmt/pull/426)) – [@​fredyw](https://togithub.com/fredyw), [@​hick209](https://togithub.com/hick209) - Fix empty enum parse error ([https://github.com/facebook/ktfmt/pull/425](https://togithub.com/facebook/ktfmt/pull/425)) – [@​fredyw](https://togithub.com/fredyw) - Preserving empty enums semicolons ([https://github.com/facebook/ktfmt/pull/434](https://togithub.com/facebook/ktfmt/pull/434)) – [@​nreid260](https://togithub.com/nreid260) - Always use UTF8 ([https://github.com/facebook/ktfmt/pull/437](https://togithub.com/facebook/ktfmt/pull/437)) – [@​nreid260](https://togithub.com/nreid260) - IntelliJI DEA plugin update ([https://github.com/facebook/ktfmt/pull/420](https://togithub.com/facebook/ktfmt/pull/420)) – [@​greyhairredbear](https://togithub.com/greyhairredbear) - Managing trailing commas in enums ([https://github.com/facebook/ktfmt/pull/449](https://togithub.com/facebook/ktfmt/pull/449)) – [@​nreid260](https://togithub.com/nreid260) - Badges on README ([https://github.com/facebook/ktfmt/pull/448](https://togithub.com/facebook/ktfmt/pull/448), [https://github.com/facebook/ktfmt/pull/453](https://togithub.com/facebook/ktfmt/pull/453)) – [@​JavierSegoviaCordoba](https://togithub.com/JavierSegoviaCordoba), [@​hick209](https://togithub.com/hick209) - Emit parsing error for calls with multiple trailing lambdas ([https://github.com/facebook/ktfmt/pull/457](https://togithub.com/facebook/ktfmt/pull/457)) – [@​nreid260](https://togithub.com/nreid260) - Removed duplicated line in editorconfig file ([https://github.com/facebook/ktfmt/pull/456](https://togithub.com/facebook/ktfmt/pull/456)) – [@​sabufung30](https://togithub.com/sabufung30) Big thanks to all the contributors! **Full Changelog**: facebook/ktfmt@v0.47...v0.48 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ZacSweers/CatchUp). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Zac Sweers <[email protected]>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
AsyncDocumentFormattingServiceimplementation to format code withktfmt(adjusted fromgoogle-java-formatIDEA plugin)Intended to fix #399(IDEA plugin seems to have been published for0.46)