Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDEA plugin is not published since 0.43 #399

Closed
sergei-lapin opened this issue Apr 29, 2023 · 9 comments
Closed

IDEA plugin is not published since 0.43 #399

sergei-lapin opened this issue Apr 29, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@sergei-lapin
Copy link

There's nothing much to add to the title: there are no nor 0.43 nor 0.44 version of IDEA plugin present on JetBrains marketplace

@cgrushko
Copy link
Contributor

Our plugin (which is a copy-paste of google-java-format's) has had compatibility issues for some time now (i.e., APIs that JetBrains deprecated) but we never got around to updating the plugin. Looks like JetBrains now rejects updates that still have these compatibility issues (which is reasonable).

The path forward is to copy-paste google-java-format's plugin again and apply our changes on top of the fork.

@jiqimaogou
Copy link

I think we can have a jar publish in github, so we can install it offline

@simonhauck
Copy link

Hi,

I wanted to ask if there are any updates regarding this issue.

We just stumbled across this issue today in our project, since the gradle ktfmt plugin has now updated to the latest version of ktfmt and the formatting changed. Now the IntelliJ plugin and the format tasks generate different outputs and it would be amazing to have the auto save functionality back :)

Is there any way we can support?

@greyhairredbear
Copy link
Contributor

I'd be happy to give the copy-paste approach proposed by @cgrushko a try and open a PR if I don't run into any unexpected issues.

@JavierSegoviaCordoba
Copy link
Contributor

@greyhairredbear any update? If you got some blocker maybe getting it published on Github as a zip would be a workaround for a while.

@greyhairredbear
Copy link
Contributor

Haven't really gotten to it unfortunately. Mainly took a look around the google-java-format plugin code. I have the impression it should not be too much of a hassle, maybe I'll have some time to spare on one evening this week - but no guarantees there.

@greyhairredbear
Copy link
Contributor

Just as a small heads up: Started working on this, but I can't make any promises how much time I can spend. Any changes I push should be visible in #420

@okarmazin
Copy link

FYI 1.1.0.46 is published again

image

@greyhairredbear
Copy link
Contributor

Correct, already have it in use. I suppose it still would make sense to merge #420 (or if the updated plugin is based on some other unmerged code that code) at some point - just to be on par with the google-java-format plugin and not use deprecated APIs anymore.

@hick209 hick209 added the bug Something isn't working label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants