Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnDropFiles: Add support for spaces and quotes in filename #1728

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mwestphal
Copy link
Contributor

@mwestphal mwestphal commented Nov 23, 2024

OnDropFiles() needs to escape quotes in filenames before adding quotes around them.
Also TriggerBinding() should add a space between commands and first argument instead of expecting said space to be there already.

Test for spaces in filename is not supported by the interaction testing mechanism.
Test for quotes in filename is supported but github actions do not like quotes in filenames, so testing is limited.

Superseed #1725

@mwestphal mwestphal changed the title Fix dropped filename quoting OnDropFiles: Add support for spaces and quotes in filename Nov 23, 2024
@mwestphal
Copy link
Contributor Author

@snoyer @Meakk please review

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.96%. Comparing base (78ff702) to head (35f1cf3).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1728      +/-   ##
==========================================
- Coverage   96.96%   96.96%   -0.01%     
==========================================
  Files         108      110       +2     
  Lines        8792     8823      +31     
==========================================
+ Hits         8525     8555      +30     
- Misses        267      268       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants