Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape quotes in dropped filenames #1725

Closed
wants to merge 2 commits into from

Conversation

snoyer
Copy link
Contributor

@snoyer snoyer commented Nov 20, 2024

OnDropFiles() needs to escape quotes in filenames before adding quotes around them.
Also TriggerBinding() should add a space between commands and first argument instead of expecting said space to be there already.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.96%. Comparing base (78ff702) to head (6dd3296).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1725   +/-   ##
=======================================
  Coverage   96.96%   96.96%           
=======================================
  Files         108      108           
  Lines        8792     8805   +13     
=======================================
+ Hits         8525     8538   +13     
  Misses        267      267           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mwestphal
Copy link
Contributor

Ideally a test using a file with a name withs spaces should be added/modified into, but I can take care of it if needed.

@mwestphal
Copy link
Contributor

superseeded by #1728

@mwestphal mwestphal closed this Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants