Skip to content

Commit

Permalink
Remove the implementation of block-GMRES (#287)
Browse files Browse the repository at this point in the history
  • Loading branch information
@amontoison
amontoison authored Dec 8, 2023
1 parent 34cb0d2 commit bf91811
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 559 deletions.
5 changes: 3 additions & 2 deletions NEWS.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@ ExaPF release notes

Version 0.11 (December 5th, 2023)
---------------------------------
- Remove the block-GMRES implementation

This comment has been minimized.

Sign in to view

Copy link
@frapac

frapac Dec 8, 2023

Member

@JuliaRegistrator register
- Remove custom BICGSTAB implementations
- Using KrylovPreconditioners.jl for the block-Jacobi preconditioner
- Adding scaling for Krylov methods
- Use KrylovPreconditioners.jl for the block-Jacobi preconditioner
- Add scaling for Krylov methods
- Use KLU per default
- Added new benchmark scripts for linear solvers

Expand Down
12 changes: 0 additions & 12 deletions docs/src/lib/linearsolver.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,3 @@ A default solver is provided for each vendor backend.
default_linear_solver
```

## Block-Krylov solvers

`ExaPF.jl` provides an implementation of block-GMRES to solve linear systems
with multiple righ-hand sides.

```@docs
BlockKrylovSolver
BlockGmresSolver
block_gmres
block_gmres!
```
5 changes: 1 addition & 4 deletions src/LinearSolvers/LinearSolvers.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import ..ExaPF: xnorm
import Base.size, Base.sizeof, Base.format_bytes

using KLU
import Krylov: KrylovStats, allocate_if, ksizeof, FloatOrComplex, ktimer, matrix_to_vector, kdisplay, mulorldiv!
import Krylov
using KrylovPreconditioners

const KA = KernelAbstractions
Expand All @@ -35,9 +35,6 @@ export do_scaling, scaling!
Diverged,
)

include("utils.jl")
include("block_gmres.jl")

abstract type AbstractLinearSolver end
abstract type AbstractIterativeLinearSolver <: AbstractLinearSolver end

Expand Down
348 changes: 0 additions & 348 deletions src/LinearSolvers/block_gmres.jl
View file

This file was deleted.

Loading

1 comment on commit bf91811

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/96761

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.11.0 -m "<description of version>" bf918111c7b4e7ded584712574d96bce1d9fb101
git push origin v0.11.0

Please sign in to comment.