Add a workflow with Aqua.jl (#289)

* Add a workflow with Aqua.jl * Remove undefined exported symbols * Add a compat entry for AMDGPU.jl
exanauts · Dec 7, 2023 · 34cb0d2 · 34cb0d2
1 parent 0ce95bc
commit 34cb0d2
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/.github/workflows/Aqua.yml b/.github/workflows/Aqua.yml
@@ -0,0 +1,17 @@
+name: Aqua
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    types: [opened, synchronize, reopened]
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: julia-actions/setup-julia@latest
+        with:
+          version: '1'
+      - name: Aqua.jl
+        run: julia --color=yes -e 'using Pkg; Pkg.add("Aqua"); Pkg.develop(path="."); using Aqua, ExaPF; Aqua.test_all(ExaPF, ambiguities=false); Aqua.test_ambiguities(ExaPF)'
diff --git a/Project.toml b/Project.toml
@@ -26,6 +26,7 @@ ExaPFCUDAExt = "CUDA"
 
 [compat]
 Adapt = "3.3"
+AMDGPU = "0.8"
 CUDA = "4.1, 5"
 ForwardDiff = "0.10"
 KernelAbstractions = "0.9"

diff --git a/src/LinearSolvers/LinearSolvers.jl b/src/LinearSolvers/LinearSolvers.jl
@@ -22,8 +22,8 @@ using KrylovPreconditioners
 const KA = KernelAbstractions
 const KP = KrylovPreconditioners
 
-export bicgstab, list_solvers, default_linear_solver
-export DirectSolver, BICGSTAB, EigenBICGSTAB, Bicgstab
+export list_solvers, default_linear_solver
+export DirectSolver, Bicgstab
 export do_scaling, scaling!
 
 @enum(