Update EIP-7685: exclude empty requests data in commitment #8989
+17
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here I am proposing to change the `requests_hash` commitment so that empty items are excluded. The point of this is to ensure a stable empty requests hash which is independent of fork. Having such a hash makes testing a lot easier, and it mirrors how other execution-layer commitments behave.
github-actions
bot
added
c-update
File
|
eth-bot
changed the title
This was referenced Oct 22, 2024
| for r in requests: | ||
| m.update(sha256(r)) | ||
| for r in block_requests: | ||
| if len(r) > 1: |
There was a problem hiding this comment.
Ok, this works, but this assumes that request_type is one byte, which is not specified.
I would also somewhere note that this thus checks that there is any request_data (without request_data then r len is indeed 1 (assuming that it is a Bytes1 type)). I initially thought this was off and should be len(r) >= 1.
There was a problem hiding this comment.
The type will always be one byte. We should probably add that to the EIP.
To me this is already a good reason for the change! :) |
58 tasks
3 tasks
16 tasks
etan-status
added a commit
to status-im/nimbus-eth2
that referenced
this pull request
Nov 21, 2024
The `requestType` of empty lists is no longer part of the requests hash. - ethereum/EIPs#8989
etan-status
reviewed
Nov 21, 2024
EIPS/eip-7685.md
Outdated
| m.update(sha256(r)) | ||
| for r in block_requests: | ||
| if len(r) > 1: | ||
| m.update(sha256(r)) |
There was a problem hiding this comment.
Suggested change
| m.update(sha256(r)) | |
| m.update(sha256(r).digest()) |
tersec
pushed a commit
to status-im/nimbus-eth2
that referenced
this pull request
Nov 24, 2024
* Adopt latest changes to request hash computation The `requestType` of empty lists is no longer part of the requests hash. - ethereum/EIPs#8989 * Avoid nested computeDigest scopes
MarekM25
approved these changes
Nov 25, 2024
g11tech
previously approved these changes
Nov 25, 2024
jochem-brouwer
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I am proposing to change the
requests_hashcommitment so that empty items are excluded. The point of this is to ensure a stable empty requests hash which is independent of fork. Having such a hash makes testing a lot easier, and it mirrors how other execution-layer commitments behave.There is also a corresponding engine API change: ethereum/execution-apis#599