Exclude empty requests in requests list #3998
Merged
+234
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensi321
reviewed
Oct 29, 2024
ralexstokes
reviewed
Oct 30, 2024
Co-authored-by: Alex Stokes <[email protected]>
ralexstokes
reviewed
Oct 30, 2024
3 tasks
ensi321
approved these changes
Nov 5, 2024
ppopth
reviewed
Nov 6, 2024
hwwhww
approved these changes
Nov 21, 2024
Comment on lines
+145
to
+147
| | `DEPOSIT_REQUEST_TYPE` | `Bytes1('0x00')` | | ||
| | `WITHDRAWAL_REQUEST_TYPE` | `Bytes1('0x01')` | | ||
| | `CONSOLIDATION_REQUEST_TYPE` | `Bytes1('0x02')` | |
There was a problem hiding this comment.
For CL specs, they should be named with REQUEST_TYPE_*, but I figured out they are EIP constants... 😭
@lightclient is it too late to change?
Request hash is not considered in `compute_el_block_hash`, have to use one of the other overloads for this to work.
Fix block hash computation for deposit transition tests
Request hash is not considered in `compute_el_block_hash`, have to use one of the other overloads for this to work.
etan-status
approved these changes
Nov 22, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrors changes suggested by Felix here: