full eslint

[tharvik]

found out that eslint was not working on much files (ie, only on javascript files that we don't have anymore).

• commonize the eslint configuration to process all typescript files around
• fix a bunch of lint issues
• also making discojs-core platform independant, by using isomorphic-* libs and ES standards
  • upstream isomorphic-wrtc is answering slowly, keeping an updated version around until then

[JulienVig]

Very nice!

It seems node-webrtc doesn't support Apple Silicon, indeed on M2 running npm ci raises this error:

npm ERR! code 1
npm ERR! path /Users/vignoud/Disco/review_repo/node_modules/wrtc
npm ERR! command failed
npm ERR! command sh -c -- node scripts/download-prebuilt.js
npm ERR! response status 404 Not Found on https://node-webrtc.s3.amazonaws.com/wrtc/v0.4.7/Release/darwin-arm64.tar.gz
npm ERR! node-pre-gyp info it worked if it ends with ok
npm ERR! node-pre-gyp info using [email protected]
npm ERR! node-pre-gyp info using [email protected] | darwin | arm64
npm ERR! node-pre-gyp info check checked for "/Users/vignoud/Disco/review_repo/node_modules/wrtc/build/Release/wrtc.node" (not found)
npm ERR! node-pre-gyp http GET https://node-webrtc.s3.amazonaws.com/wrtc/v0.4.7/Release/darwin-arm64.tar.gz
npm ERR! node-pre-gyp ERR! install response status 404 Not Found on https://node-webrtc.s3.amazonaws.com/wrtc/v0.4.7/Release/darwin-arm64.tar.gz
npm ERR! node-pre-gyp ERR! install error
npm ERR! node-pre-gyp ERR! stack Error: response status 404 Not Found on https://node-webrtc.s3.amazonaws.com/wrtc/v0.4.7/Release/darwin-arm64.tar.gz
npm ERR! node-pre-gyp ERR! stack     at /Users/vignoud/Disco/review_repo/node_modules/@mapbox/node-pre-gyp/lib/install.js:67:15
npm ERR! node-pre-gyp ERR! stack     at processTicksAndRejections (node:internal/process/task_queues:96:5)
npm ERR! node-pre-gyp ERR! System Darwin 23.3.0
npm ERR! node-pre-gyp ERR! command "/Users/vignoud/.nvm/versions/node/v16.20.2/bin/node" "/Users/vignoud/Disco/review_repo/node_modules/.bin/node-pre-gyp" "install"
npm ERR! node-pre-gyp ERR! cwd /Users/vignoud/Disco/review_repo/node_modules/wrtc
npm ERR! node-pre-gyp ERR! node -v v16.20.2
npm ERR! node-pre-gyp ERR! node-pre-gyp -v v1.0.11
npm ERR! node-pre-gyp ERR! not ok

I found a few open issues with a similar installation error:

• #680
• #698
• #725
• #729
• others I didn't check

None of the fixes I tried worked on M2. I didn't try this one.

FYI issue #698 mentions using @koush/wrtc instead, which I see you removed from the dependencies. I tried npm i @koush/wrtc anyway but still doesn't work so I don't know what changed compared to when it used to work on my M2.

[tharvik]

It seems node-webrtc doesn't support Apple Silicon
[...]
FYI issue #698 mentions using @koush/wrtc instead, which I see you removed from the dependencies. I tried npm i @koush/wrtc anyway but still doesn't work so I don't know what changed compared to when it used to work on my M2.

ho it remaines me that we add that, I though it was an issue of early userspace M2 support and that was fixed in the meantime. looks like it wasn't.

wrtc is an abandonned project, a bunch of people are actually building it by themself, publishing binaries around but there isn't a concerted effort. it'll be nice to actually get rid of it a some point and use node-datachannel that seems more modern. tracking in #633.
for quick fixes, @koush/wrtc was last released 2y ago, I'm more in favor of using @roamhq/wrtc that got released some months ago (and is the only one that updated its readme expliciting support for node-18) we are still at node-16, I mixed my PRs oupsi

[tharvik]

@JulienVig as I don't have a M2 around, can you try out the latest commit plz? :)

[JulienVig]

Very nice, the code is much cleaner!

I saw you created a new module isomorphic-wrtc, could you maybe add a few lines of explanation in the doc about what's the purpose of this module? For example as a README.md in the isomorphic-wrtc or in the Structure section of DEV.md

Unnoticed error

[JulienVig]

npm -ws run build fails because the isomorphic-wrtc doesn't have a build script:

Lifecycle script build failed with error:
npm ERR! Error: Missing script: "build"

[tharvik]

I saw you created a new module isomorphic-wrtc, could you maybe add a few lines of explanation in the doc about what's the purpose of this module?

indeed, it's a bit cryptic when you first come to the project. added some infos in isomorphic-wrtc/README.md

npm -ws run build fails because the isomorphic-wrtc doesn't have a build script:

ho right, I didn't check the return code when doing that. added empty scripts for build/lint/test

[JulienVig]

Looks good to me!