discojs-core: drop node:url

epfml · Feb 12, 2024 · f4ba129 · f4ba129
1 parent f02c0cd
commit f4ba129
Show file tree

Hide file tree

Showing 8 changed files with 7 additions and 11 deletions.
diff --git a/discojs/discojs-core/package.json b/discojs/discojs-core/package.json
@@ -29,7 +29,6 @@
     "msgpack-lite": "0.1",
     "simple-peer": "9",
     "tslib": "2",
-    "url": "0.11",
     "ws": "8"
   },
   "devDependencies": {

diff --git a/discojs/discojs-core/src/client/base.ts b/discojs/discojs-core/src/client/base.ts
@@ -1,5 +1,5 @@
-import { Set } from 'immutable'
 import axios from 'axios'
+import { Set } from 'immutable'
 
 import { tf, Task, TrainingInformant, serialization, WeightsContainer } from '..'
 import { NodeID } from './types'

diff --git a/discojs/discojs-core/src/client/decentralized/base.ts b/discojs/discojs-core/src/client/decentralized/base.ts
@@ -1,5 +1,4 @@
 import { Map, Set } from 'immutable'
-import * as nodeUrl from 'url'
 
 import { TrainingInformant, WeightsContainer, serialization } from '../..'
 import { Client, NodeID } from '..'
@@ -96,7 +95,6 @@ export class Base extends Client {
   }
 
   async connect (): Promise<void> {
-    const URL = typeof window !== 'undefined' ? window.URL : nodeUrl.URL
     const serverURL = new URL('', this.url.href)
     switch (this.url.protocol) {
       case 'http:':

diff --git a/discojs/discojs-core/src/client/event_connection.ts b/discojs/discojs-core/src/client/event_connection.ts
@@ -1,4 +1,4 @@
-import isomorphic, { WebSocket } from 'isomorphic-ws'
+import WebSocket from 'isomorphic-ws'
 import { EventEmitter } from 'events'
 import { Peer } from './decentralized/peer'
 import { NodeID } from './types'
@@ -109,7 +109,7 @@ export class WebSocketServer implements EventConnection {
     const emitter: EventEmitter = new EventEmitter()
     const server: WebSocketServer = new WebSocketServer(ws, emitter, validateReceived, validateSent)
 
-    ws.onmessage = (event: isomorphic.MessageEvent) => {
+    ws.onmessage = (event: WebSocket.MessageEvent) => {
       if (!(event.data instanceof ArrayBuffer)) {
         throw new Error('server did not send an ArrayBuffer')
       }
@@ -125,7 +125,7 @@ export class WebSocketServer implements EventConnection {
     }
 
     return await new Promise((resolve, reject) => {
-      ws.onerror = (err: isomorphic.ErrorEvent) =>
+      ws.onerror = (err: WebSocket.ErrorEvent) =>
         reject(new Error(`connecting server: ${err.message}`)) // eslint-disable-line @typescript-eslint/restrict-template-expressions
       ws.onopen = () => resolve(server)
     })

diff --git a/discojs/discojs-core/src/client/federated/base.ts b/discojs/discojs-core/src/client/federated/base.ts
@@ -1,4 +1,3 @@
-import * as nodeUrl from 'url'
 import { Map } from 'immutable'
 
 import { serialization, informant, MetadataKey, MetadataValue, WeightsContainer, TrainingInformant } from '../..'
@@ -43,7 +42,6 @@ export class Base extends Client {
    * for the task.
    */
   async connect (): Promise<void> {
-    const URL = typeof window !== 'undefined' ? window.URL : nodeUrl.URL
     const serverURL = new URL('', this.url.href)
     switch (this.url.protocol) {
       case 'http:':

diff --git a/discojs/discojs-core/src/task/task_handler.ts b/discojs/discojs-core/src/task/task_handler.ts
@@ -1,5 +1,5 @@
-import { Map } from 'immutable'
 import axios from 'axios'
+import { Map } from 'immutable'
 
 import { serialization, tf, WeightsContainer } from '..'
 import { isTask, Task, TaskID } from './task'

diff --git a/discojs/discojs-web/tsconfig.json b/discojs/discojs-web/tsconfig.json
@@ -1,6 +1,7 @@
 {
   "extends": "../tsconfig.base.json",
   "compilerOptions": {
+    "lib": ["DOM"],
     "outDir": "dist",
     "baseUrl": "src"
   },

diff --git a/discojs/tsconfig.base.json b/discojs/tsconfig.base.json
@@ -2,7 +2,7 @@
   "compilerOptions": {
     // TODO ES6 disallow server's test
     "target": "ES5",
-    "lib": ["ES5", "DOM"],
+    "lib": ["ES5"],
 
     "strict": true,
     "noEmitOnError": true,