Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neutroswap milestone 0 delivery #136

Merged
merged 5 commits into from
Nov 14, 2023

Conversation

jonassunandar
Copy link
Contributor

Milestone Delivery Checklist

Link to the application pull request: eosnetworkfoundation/grant-framework#222 < please fill this in with the PR number of your application.

@nsjames
Copy link
Member

nsjames commented Oct 20, 2023

The second link in the docs is broken

Everything else looks fine here, except the difference between the stated milestone for the twitter threads:

  • Originally it said "Publish twitter threads"
  • But this milestone only has a typefully draft

What is the timeline for the release of those tweets?

Copy link

@wanderingbort wanderingbort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same concerns as @nsjames

I believe the second link is broken because that repo is currently private (we see a 404 for the link and the repo itself).

If that is the case, please add the reviewers to a role where they can at least view that repo and add in the document the timeline for opensourcing that repo

@jonassunandar
Copy link
Contributor Author

Sorry about the broken link. Now there's no broken link and we have posted the V2 post. Please kindly check again @nsjames @wanderingbort

Copy link

@DenisCarriere DenisCarriere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonassunandar
Copy link
Contributor Author

Hi @tedcahalleos, is there anything else I need to add for milestone 0? Neutroswap V2 smart contracts are ready, and we'd like to create new PR for the next milestone

@tedcahalleos tedcahalleos added Milestone-Approved The Milestone has been approved and will be paid. Milestone-Received The Milestone submission has been received by Operations and removed 👍 lgtm labels Nov 14, 2023
@tedcahalleos tedcahalleos merged commit 16d854e into eosnetworkfoundation:main Nov 14, 2023
@jonassunandar jonassunandar mentioned this pull request Jan 4, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Milestone-Approved The Milestone has been approved and will be paid. Milestone-Received The Milestone submission has been received by Operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants