Neutroswap Milestone 1&2

[jonassunandar]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• The invoice form has been filled out for this milestone.
• This pull request is being made by the same account as the accepted application.
• In case of acceptance, the payment will be transferred to the EOS account name provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: #136 < please fill this in with the PR number of your application.

[nsjames]

Hello!
I'm going through the materials and I found a few issues.

• License file link is not working, and I don't see a license in the repository
• The following contracts don't have their code verified:
  • 0x5f4b3D92bcb944a0e9B231C42D0615F8A27Bbcc0 (NitroPoolFactory)
  • 0x72076068Bd08f5D0AE541075f1E317b3B1d46d8f (FairAuctionFactory)
• The analytics page link is broken

(I see some issue with the explorer not be able to load the 0x96A064DB6CA1D45e59756D3DAc7CD249D4D742030 address right now and have elevated internally)

Something seems to be broken with subgraph development links

---

Contract foundry tests are all passing 👍

[jonassunandar]

Hi @nsjames thanks for pointing some issues

• Analytics link is changed to https://analytics.neutroswap.io/. We change the analytics directly to mainnet to test the accuracy of The Graph and for clearer data
• Currently V2 contracts are being audited now by SolidProof. No changes from the submitted contracts. Hopefully within this week we will update and verified all the contracts
• License and The Graph issues, I'll bring it to the team

[nsjames]

Thanks, looking forward to closing this one out 🙏 (I know we've been going back and forth for a while on tg)

[jonassunandar]

• License file link is not working, and I don't see a license in the repository
  Something seems to be broken with subgraph development links

Hi James

1. The graph issues: you need to query some variables to test it. For example to get available all pairs here

2. We have added the licenses here: Neutroswap app and V2 contracts

Please let me know if you found other issues

[nsjames]

Thanks, just waiting for those contracts to be verified and we're good to go.

[jonassunandar]

Hi @nsjames
All the mainnet contracts are verified and audited by SolidProof. Please take a look at here

[nsjames]

Looking good, thanks!

[jonassunandar]

Hi guys, is there be any specific areas of our milestone that require additional discussion or clarification, please do not hesitate to reach out @tedcahalleos @nsjames @wanderingbort @BenjaminGormanPMP

[tedcahalleos]

Approved.