Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple 'checks' workflow for PR and Merge events #10

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Add simple 'checks' workflow for PR and Merge events #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 57 additions & 0 deletions .github/workflows/checks.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
name: Checks
on:
pull_request:
branches:
- main
push:
branches:
- main
workflow_dispatch:

jobs:
ci:
runs-on: ubuntu-latest
outputs:
status: ${{ job.status }}
steps:
- name: Checkout code
uses: actions/checkout@v2

- name : Run EC Validate (keyless)
uses: ./
with:
image: ghcr.io/enterprise-contract/golden-container:latest
identity: https:\/\/github\.com\/(slsa-framework\/slsa-github-generator|enterprise-contract\/golden-container)\/
issuer: https://token.actions.githubusercontent.com

#FIXME Commented out because the golden-image on quay.io is failing due to a violation in the image.
# - name : Run EC Validate (Long_Lived)
# uses: ./
# with:
# image: quay.io/redhat-appstudio/ec-golden-image:latest
# key: ${{ vars.PUBLIC_KEY }}
# policy: github.com/enterprise-contract/config//slsa3
# extra-params: --ignore-rekor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's explain more clearly in comments why this is commented out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done hopefully more clear now 👍🏻

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this change fixed it: enterprise-contract/golden-container#129

As a side note. Usually, a comment like this would go as the first line of the commented out block so it is obvious to the reader, e.g.:

    # FIXME Commented out because ...
    # - name : Run EC Validate (Long_Lived)
    #   uses: ./
    #   with:

Copy link
Contributor Author

@seanconroy2021 seanconroy2021 Oct 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is now a warning I am going try fix it. I think we will leave it commented out for time being

 warnings:
  - metadata:
      code: slsa_source_correlated.source_code_reference_provided
    msg: Expected source code reference was not provided for verification


release:
runs-on: ubuntu-latest
needs: ci
if: needs.ci.outputs.status == 'success' && github.ref == 'refs/heads/main' && github.event_name != 'pull_request'
steps:
- name: Get Latest Version Tag and Increment
run: |
# Find the version tag and then increment new version with v prefix eg. v1.0.1 -> v1.0.2
latestVTag=$(gh api -H 'Accept: application/vnd.github.v3+json' /repos/${{ github.repository }}/releases/latest -q '.tag_name')
echo "newVersion=v$(echo ${latestVTag#v} | awk -F. '{$NF = $NF + 1;} 1' OFS=.)" >> $GITHUB_ENV
env:
GH_TOKEN: ${{ github.token }}

- name: Create New Version Release
seanconroy2021 marked this conversation as resolved.
Show resolved Hide resolved
uses: softprops/action-gh-release@v1
with:
name: ${{ env.newVersion }} Release
body: ""
tag_name: ${{ env.newVersion }}
generate_release_notes: true
draft: false
prerelease: false
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,11 @@ jobs:

steps:
- name: Run EC Validator
uses: enterprise-contract/action-validate-image@v1.1
uses: enterprise-contract/action-validate-image@latest
with:
image: "quay.io/redhat-appstudio/ec-golden-image:latest"
image: quay.io/redhat-appstudio/ec-golden-image:latest
key: ${{ vars.PUBLIC_KEY }}
policy: "github.com/enterprise-contract/config//default"
policy: github.com/enterprise-contract/config//slsa3
extra-params: --ignore-rekor
```

Expand All @@ -109,7 +109,7 @@ jobs:

steps:
- name: Run EC Validator
uses: enterprise-contract/action-validate-image@v1.1
uses: enterprise-contract/action-validate-image@latest
with:
image: quay.io/lucarval/festoji:latest
identity: https:\/\/github\.com\/(slsa-framework\/slsa-github-generator|lcarva\/festoji)\/
Expand Down
Loading