-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add simple 'checks' workflow for PR and Merge events #10
Conversation
Do we need a "latest" release? Can it just be inferred from the release with the highest version? Someone could always use Suggestion: Just stick to semver for releases. |
@lcarva Thanks for the review. I have fixed the problems 👍🏻 |
# image: quay.io/redhat-appstudio/ec-golden-image:latest | ||
# key: ${{ vars.PUBLIC_KEY }} | ||
# policy: " " #TODO Ignore until image is fixed | ||
# extra-params: --ignore-rekor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's explain more clearly in comments why this is commented out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done hopefully more clear now 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if this change fixed it: enterprise-contract/golden-container#129
As a side note. Usually, a comment like this would go as the first line of the commented out block so it is obvious to the reader, e.g.:
# FIXME Commented out because ...
# - name : Run EC Validate (Long_Lived)
# uses: ./
# with:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is now a warning I am going try fix it. I think we will leave it commented out for time being
warnings:
- metadata:
code: slsa_source_correlated.source_code_reference_provided
msg: Expected source code reference was not provided for verification
This workflow automates the following tasks: 1. On pull requests to the 'main' branch, it runs a basic CI check. 2. On pushes or merges to the 'main' branch, it runs the CI check. If successful, it triggers the 'release' job, which performs the following actions: - Determines the current version (e.g., v1.0.1) and increments it to create a new version (e.g., v1.0.2). - Creates a new version release with the updated tag (e.g., v1.0.2). resolves: HACBS-2725 Signed-off-by: Sean Conroy [email protected]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this so we can see it in action and address any wrinkles later.
Add simple 'checks' workflow for PR and Merge events
Add simple 'checks' workflow for PR and Merge events
This workflow automates the following tasks:
On pull requests to the 'main' branch, it runs a basic CI check.
On pushes or merges to the 'main' branch, it runs the CI check. If successful, it triggers the 'release' job, which performs the following actions: