Changes for GDPR compliance.

[lsh-0]

No description provided.

[lsh-0]

@discodavey , here's a question, how do I tie this change of pattern-library to a journal PR via patterns-php?

From my understanding:

1. branch patterns-library, make the change
2. branch patterns-php, switch to a version of patterns-library using bin/update
3. pin patterns-php revision in journal

It's step 2 I'm stuck on. My goal is to update https://pr-1849--journal.elifesciences.org with the changes

[discodavey]

@lsh-0 You normally merge the Pattern Library PR.

This will then in turn create a PR in patterns-php and you then do the same again with that PR and merge it.

That will create a PR in Journal for you to test and then merge for the final time

[lsh-0]

Hrm. This may turn out to be a dead end. I need to figure out a way to test this before merging.

[discodavey]

@lsh-0 If you need anymore info then please shout

[lsh-0]

No worries, thanks @discodavey

[lsh-0]

@discodavey , @viktoria-mahmud , I can't figure out how to test changes to main.js without first merging to develop and then launching a test instance so I'd be grateful for any feedback you have before I merge this in.

[discodavey]

The way to do this is to create a feature branch in patterns-php and then bring in the feature branch from pattern-library.
./bin/update pr-1303

Then you do the same for journal where you bring in the feature branch created from patterns-php.

COMPOSER_MEMORY_LIMIT=-1 composer require elife/patterns:dev-NAME_OF_NEW_PATTERNS_PHP_BRANCH

This will mean nothing gets merged and you can then see whether it works or not. Does this make sense?

[lsh-0]

That was very helpful, thanks @discodavey .

I'm now able to debug the changes and make sure they're working without doing anything dangerous, cheers.