Cookiebot changes for GDPR compliance. #1849
Open
+55
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lsh-0
commented
Feb 19, 2024
•
lsh-0
commented
- tests are broken and disabled, re-enable and fix
- tests are broken again
- changes to main.js not present in https://pr-1849--journal.elifesciences.org , but some of the changes to html are
- review
page.html.twig, re-enables auto-blocking mode, classifies Hypothesis as statistics collection. issues #8371 and #8513
page.html.twig, marks up scripts as text/plain. page.html.twig, removes iframe with link to google tag manager. without javascript there is no cookiebot and without cookiebot there is no means to consent or withdraw consent.
it isn't what I thought it was
lsh-0
commented
Feb 28, 2024
lsh-0
commented
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.