-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share popup modal separation #1107
Draft
discodavey
wants to merge
68
commits into
develop
Choose a base branch
from
share-popup-modal-separation
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
b193b42
Journal article main content updates (#1101)
discodavey 4a282e0
Initial work for creating share modal popup
discodavey 3e35473
Add table variations and fix bug for lists inside tables (#1104)
discodavey ced7d4d
Table list indentation issue (#1105)
discodavey 0acea23
Changes to js and adding data behaviour
discodavey 6ab193f
Fix css for modal
discodavey a9eb22b
removing console logs on modal
discodavey 8839aa0
Merge branch 'develop' into share-popup-modal
discodavey b60b0fd
Move modal-window to atoms
nlisgo 1e4a664
Adding modal json file for parameters
discodavey 0aca963
Add yaml parameters for modal window
discodavey a16bbbb
Add variations for modal window
discodavey 63a0c12
Add share modal content and styling
discodavey 4a60f40
Add Citations json and template changes
discodavey 667a147
Styling citations
discodavey dd3b44b
Add without link to doi atom
discodavey 46d2179
Introduce doi variant without a link
nlisgo cde76eb
Cleanup of duplication in doi and reference templates
nlisgo e244a97
no-wtf
nlisgo 9bd47e3
Move all modals to atoms and refactor css
discodavey 813f6d8
Refactor content for json file modal window
discodavey 30d43a3
Adding Clipboard JS for modal window share and citations
discodavey 7811f62
Add button success
discodavey 72a2974
Button styling on modal windows
discodavey 3f3c044
Remove border
discodavey 686b3ac
Refactor code and some fixes
discodavey c716c0a
Adding socials to this PR from old PR
discodavey e21ab97
Remove Close text for modal share
discodavey f375e88
Refactor styling on modal
discodavey 7ecfb1d
Refactor modal window css and template
discodavey 123ff6a
Refactor Modal Windows
discodavey baf406b
Refactor json files for Modal Window
discodavey 7793ab3
Merge branch 'develop' into share-popup-modal-separation
discodavey e7b4a52
Add button collection to modal citations
discodavey 34e1cf5
Refactor colours to variables on button--secondary
discodavey 4aebeb0
Remove redundant properties
nlisgo a30d6d1
Add new button-collection variant
nlisgo 14b04d8
Merge branch 'share-popup-modal-separation' of github.com:elifescienc…
nlisgo bdfcae4
refactor hover state for button--secondary
discodavey b3012d1
Add button secondary variant
nlisgo 28604a7
Adjust classes
nlisgo d0b6eca
Remove some styles
nlisgo 6fdf7da
Add condition
nlisgo 6eaebdb
Clean data
nlisgo 38a7311
Merge branch 'share-popup-modal-separation' of github.com:elifescienc…
nlisgo 2ddbc17
Add styling for refactored buttons for citations modal window
discodavey e03fb9e
Introduce button clipboard and button collection to modal
nlisgo f2c5f7a
Merge branch 'share-popup-modal-separation' of github.com:elifescienc…
nlisgo 5d2212c
Allow a trigger id to be set for the modal
nlisgo fbbffbd
adding email icon for share modal window
discodavey 69b22eb
refactor url paths for social media icons
discodavey deb7c5f
Merge branch 'develop' into share-popup-modal-separation
discodavey 1b9e25f
Introduce placeholder for test for button clipboard
nlisgo 0476e36
skip placeholder test
nlisgo ca88a76
Refactor social media sharers for modal share
discodavey f150381
Update json files for social media sharers with LinkedIn url
discodavey 90b61ff
Allow button clipboard copy function to be overwritten for tests
nlisgo 1afb84a
Merge branch 'share-popup-modal-separation' of github.com:elifescienc…
nlisgo d012c92
Refactoring modal citation and share styling and adapting for journal…
discodavey 590f017
Mock copyToClipboard method
nlisgo 830db93
Add linkedInUrl to socialMediaSharers
nlisgo a7d7725
match schema
nlisgo 4e5c79f
Removing as not anything to do with the project
discodavey 223aedb
Merge branch 'share-popup-modal-separation' of https://github.com/eli…
discodavey ad77a7f
Refactor css for modal window
discodavey 815ecb4
Reverted back to previous
discodavey b56e787
Merge branch 'develop' of github.com:elifesciences/pattern-library in…
nlisgo c85d97f
remove file and redundant sass
nlisgo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -82,9 +82,8 @@ | |
.view-selector--has-figures { | ||
display: inline-block; | ||
width: 100%; | ||
@supports (display: flex) { | ||
display: flex; | ||
} | ||
grid-column: 1/13; | ||
grid-row: 1; | ||
} | ||
|
||
.view-selector__list { | ||
|
@@ -151,8 +150,8 @@ | |
// Applied with js to stop the selector scrolling off the top of the screen. | ||
.view-selector { | ||
// Supply what was being provided by the grid now this element has been taken out the flow. | ||
@include constrain-width(210, "max"); | ||
width: 9.625rem; | ||
grid-column: 1/3; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we be sure this won't adversely affect other elements with this class? |
||
grid-row: 1; | ||
} | ||
|
||
.view-selector--fixed { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,6 @@ | |
border-bottom: 1px solid $color-text-dividers; | ||
content: ""; | ||
display: block; | ||
@include padding($content-header-padding - 1, "top"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this belong in this PR? |
||
width: 100%; | ||
} | ||
|
||
|
2 changes: 1 addition & 1 deletion
2
source/_patterns/00-atoms/components/modal-window~citations.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
{ | ||
"closeBtnText": "Close", | ||
"body": "<div class='reference'><ol class='reference__authors_list'><li class='reference__author'><a href='https://scholar.google.com/scholar?q=%22author:Schrenk%20F%22' class='reference__authors_link'>Schrenk F</a></li><li class='reference__author'> Bromage TG</li><li class='reference__author'> Betzler CG</li><li class='reference__author'> Ring U</li><li class='reference__author'> Juwayeyi YM</li><li class='reference__author'> <a href='https://scholar.google.com/scholar?q=%22author:Schrenk%20F%22' class='reference__authors_link'>Schrenk F</a></li><li class='reference__author'> Bromage TG</li><li class='reference__author'> Betzler CG</li><li class='reference__author'> Ring U</li><li class='reference__author'> Juwayeyi YM</li><li class='reference__author'> <a href='https://scholar.google.com/scholar?q=%22author:Schrenk%20F%22' class='reference__authors_link'>Schrenk F</a></li><li class='reference__author'> Bromage TG</li><li class='reference__author'> Betzler CG</li><li class='reference__author'> Ring U</li><li class='reference__author'> Juwayeyi YM</li><li class='reference__author'> <a href='https://scholar.google.com/scholar?q=%22author:Schrenk%20F%22' class='reference__authors_link'>Schrenk F</a></li><li class='reference__author'> Bromage TG</li><li class='reference__author'> Betzler CG</li><li class='reference__author'> Ring U</li><li class='reference__author'> Juwayeyi YM</li><li class='reference__author'> <a href='https://scholar.google.com/scholar?q=%22author:Schrenk%20F%22' class='reference__authors_link'>Schrenk F</a></li><li class='reference__author'> Bromage TG</li><li class='reference__author'> Betzler CG</li><li class='reference__author'> Ring U</li><li class='reference__author'>Juwayeyi YM</li></ol> <span class='reference__authors_list_suffix'>(1993)</span> Oldest <i>Homo</i> and Pliocene biogeography of the Malawi rift<div class='reference__origin'> <i>Nature</i> <strong>365</strong>:833–836.</div><span class='doi'>https://doi.org/10.1038/365833a0</span></div></div>", | ||
"body": "<div class='reference'><ol class='reference__authors_list'><li class='reference__author'><a href='https://scholar.google.com/scholar?q=%22author:Schrenk%20F%22' class='reference__authors_link'>Schrenk F</a></li><li class='reference__author'> Bromage TG</li><li class='reference__author'> Betzler CG</li><li class='reference__author'> Ring U</li><li class='reference__author'> Juwayeyi YM</li><li class='reference__author'> <a href='https://scholar.google.com/scholar?q=%22author:Schrenk%20F%22' class='reference__authors_link'>Schrenk F</a></li><li class='reference__author'> Bromage TG</li><li class='reference__author'> Betzler CG</li><li class='reference__author'> Ring U</li><li class='reference__author'> Juwayeyi YM</li><li class='reference__author'> <a href='https://scholar.google.com/scholar?q=%22author:Schrenk%20F%22' class='reference__authors_link'>Schrenk F</a></li><li class='reference__author'> Bromage TG</li><li class='reference__author'> Betzler CG</li><li class='reference__author'> Ring U</li><li class='reference__author'> Juwayeyi YM</li><li class='reference__author'> <a href='https://scholar.google.com/scholar?q=%22author:Schrenk%20F%22' class='reference__authors_link'>Schrenk F</a></li><li class='reference__author'> Bromage TG</li><li class='reference__author'> Betzler CG</li><li class='reference__author'> Ring U</li><li class='reference__author'> Juwayeyi YM</li><li class='reference__author'> <a href='https://scholar.google.com/scholar?q=%22author:Schrenk%20F%22' class='reference__authors_link'>Schrenk F</a></li><li class='reference__author'> Bromage TG</li><li class='reference__author'> Betzler CG</li><li class='reference__author'> Ring U</li><li class='reference__author'>Juwayeyi YM</li></ol> <span class='reference__authors_list_suffix'>(1993)</span> Oldest <i>Homo</i> and Pliocene biogeography of the Malawi rift<div class='reference__origin'> <i>Nature</i> <strong>365</strong>:833–836.</div><span class='doi'>https://doi.org/10.1038/365833a0</span></div><ol class='button-collection'><li class='button-collection__item'> <button class='button button--default' type='button' data-behaviour='ButtonClipboard' data-clipboard='Schrenk F Bromage TG Betzler CG Ring U Juwayeyi YM Schrenk F Bromage TG Betzler CG Ring U Juwayeyi YM Schrenk F Bromage TG Betzler CG Ring U Juwayeyi YM Schrenk F Bromage TG Betzler CG Ring U Juwayeyi YM Schrenk F Bromage TG Betzler CG Ring UJuwayeyi YM(1993) Oldest Homo and Pliocene biogeography of the Malawi rift Nature 365:833–836.https://doi.org/10.1038/365833a0'>Copy to clipboard</button></li><li class='button-collection__item'> <button class='button button--default button--secondary' type='button'>Download Bibtex</button></li><li class='button-collection__item'> <button class='button button--default button--secondary' type='button'>Download .RIS</button></li></ol>", | ||
"title": "Cite this article" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
source/_patterns/00-atoms/components/social-media-sharers.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
{ | ||
"emailUrl": "mailto:?subject=Some%20article%20title&body=https%3A%2F%2Fexample.com%2Fsome-article-url", | ||
"facebookUrl": "https://facebook.com/sharer/sharer.php?u=https%3A%2F%2Fexample.com%2Fsome-article-url", | ||
"twitterUrl": "https://twitter.com/intent/tweet/?text=Some%20article%20title&url=https%3A%2F%2Fexample.com%2Fsome-article-url", | ||
"emailUrl": "mailto:?subject=Some%20article%20title&body=https%3A%2F%2Fexample.com%2Fsome-article-url", | ||
"linkedInUrl": "https://www.linkedin.com/shareArticle?url=https%3A%2F%2Fexample.com%2Fsome-article-url", | ||
"redditUrl": "https://reddit.com/submit/?url=https%3A%2F%2Fexample.com%2Fsome-article-url" | ||
} |
45 changes: 7 additions & 38 deletions
45
source/_patterns/00-atoms/components/social-media-sharers.mustache
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,38 +1,7 @@ | ||
<div class="social-media-sharers"> | ||
|
||
{{! Skeleton autogenerated by http://sharingbuttons.io/ | ||
See notes in social-media-sharer.scss for more details. }} | ||
|
||
{{! Sharingbutton Facebook }} | ||
<a class="social-media-sharer" href="{{facebookUrl}}" target="_blank" rel="noopener noreferrer" aria-label="Share on Facebook"> | ||
<div class="social-media-sharer__icon_wrapper social-media-sharer__icon_wrapper--facebook social-media-sharer__icon_wrapper--small"><div aria-hidden="true" class="social-media-sharer__icon social-media-sharer__icon--solid"> | ||
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24"><path d="M18.77 7.46H14.5v-1.9c0-.9.6-1.1 1-1.1h3V.5h-4.33C10.24.5 9.5 3.44 9.5 5.32v2.15h-3v4h3v12h5v-12h3.85l.42-4z"/></svg> | ||
</div> | ||
</div> | ||
</a> | ||
|
||
{{! Sharingbutton Twitter }} | ||
<a class="social-media-sharer" href="{{twitterUrl}}" target="_blank" rel="noopener noreferrer" aria-label="Tweet a link to this page"> | ||
<div class="social-media-sharer__icon_wrapper social-media-sharer__icon_wrapper--twitter social-media-sharer__icon_wrapper--small"><div aria-hidden="true" class="social-media-sharer__icon social-media-sharer__icon--solid"> | ||
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24"><path d="M23.44 4.83c-.8.37-1.5.38-2.22.02.93-.56.98-.96 1.32-2.02-.88.52-1.86.9-2.9 1.1-.82-.88-2-1.43-3.3-1.43-2.5 0-4.55 2.04-4.55 4.54 0 .36.03.7.1 1.04-3.77-.2-7.12-2-9.36-4.75-.4.67-.6 1.45-.6 2.3 0 1.56.8 2.95 2 3.77-.74-.03-1.44-.23-2.05-.57v.06c0 2.2 1.56 4.03 3.64 4.44-.67.2-1.37.2-2.06.08.58 1.8 2.26 3.12 4.25 3.16C5.78 18.1 3.37 18.74 1 18.46c2 1.3 4.4 2.04 6.97 2.04 8.35 0 12.92-6.92 12.92-12.93 0-.2 0-.4-.02-.6.9-.63 1.96-1.22 2.56-2.14z"/></svg> | ||
</div> | ||
</div> | ||
</a> | ||
|
||
{{! Sharingbutton E-Mail }} | ||
<a class="social-media-sharer" href="{{emailUrl}}" target="_self" aria-label="Email a link to this page (opens up email program, if configured on this system)"> | ||
<div class="social-media-sharer__icon_wrapper social-media-sharer__icon_wrapper--email social-media-sharer__icon_wrapper--small"><div aria-hidden="true" class="social-media-sharer__icon social-media-sharer__icon--solid"> | ||
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24"><path d="M22 4H2C.9 4 0 4.9 0 6v12c0 1.1.9 2 2 2h20c1.1 0 2-.9 2-2V6c0-1.1-.9-2-2-2zM7.25 14.43l-3.5 2c-.08.05-.17.07-.25.07-.17 0-.34-.1-.43-.25-.14-.24-.06-.55.18-.68l3.5-2c.24-.14.55-.06.68.18.14.24.06.55-.18.68zm4.75.07c-.1 0-.2-.03-.27-.08l-8.5-5.5c-.23-.15-.3-.46-.15-.7.15-.22.46-.3.7-.14L12 13.4l8.23-5.32c.23-.15.54-.08.7.15.14.23.07.54-.16.7l-8.5 5.5c-.08.04-.17.07-.27.07zm8.93 1.75c-.1.16-.26.25-.43.25-.08 0-.17-.02-.25-.07l-3.5-2c-.24-.13-.32-.44-.18-.68s.44-.32.68-.18l3.5 2c.24.13.32.44.18.68z"/></svg> | ||
</div> | ||
</div> | ||
</a> | ||
|
||
{{! Sharingbutton Reddit }} | ||
<a class="social-media-sharer" href="{{redditUrl}}" target="_blank" rel="noopener noreferrer" aria-label="Share this page on Reddit"> | ||
<div class="social-media-sharer__icon_wrapper social-media-sharer__icon_wrapper--reddit social-media-sharer__icon_wrapper--small"><div aria-hidden="true" class="social-media-sharer__icon social-media-sharer__icon--solid"> | ||
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24"><path d="M24 11.5c0-1.65-1.35-3-3-3-.96 0-1.86.48-2.42 1.24-1.64-1-3.75-1.64-6.07-1.72.08-1.1.4-3.05 1.52-3.7.72-.4 1.73-.24 3 .5C17.2 6.3 18.46 7.5 20 7.5c1.65 0 3-1.35 3-3s-1.35-3-3-3c-1.38 0-2.54.94-2.88 2.22-1.43-.72-2.64-.8-3.6-.25-1.64.94-1.95 3.47-2 4.55-2.33.08-4.45.7-6.1 1.72C4.86 8.98 3.96 8.5 3 8.5c-1.65 0-3 1.35-3 3 0 1.32.84 2.44 2.05 2.84-.03.22-.05.44-.05.66 0 3.86 4.5 7 10 7s10-3.14 10-7c0-.22-.02-.44-.05-.66 1.2-.4 2.05-1.54 2.05-2.84zM2.3 13.37C1.5 13.07 1 12.35 1 11.5c0-1.1.9-2 2-2 .64 0 1.22.32 1.6.82-1.1.85-1.92 1.9-2.3 3.05zm3.7.13c0-1.1.9-2 2-2s2 .9 2 2-.9 2-2 2-2-.9-2-2zm9.8 4.8c-1.08.63-2.42.96-3.8.96-1.4 0-2.74-.34-3.8-.95-.24-.13-.32-.44-.2-.68.15-.24.46-.32.7-.18 1.83 1.06 4.76 1.06 6.6 0 .23-.13.53-.05.67.2.14.23.06.54-.18.67zm.2-2.8c-1.1 0-2-.9-2-2s.9-2 2-2 2 .9 2 2-.9 2-2 2zm5.7-2.13c-.38-1.16-1.2-2.2-2.3-3.05.38-.5.97-.82 1.6-.82 1.1 0 2 .9 2 2 0 .84-.53 1.57-1.3 1.87z"/></svg> | ||
</div> | ||
</div> | ||
</a> | ||
|
||
</div> | ||
<ul class="social-media-sharers"> | ||
<li><a class="social-media-sharer email" href="{{emailURL}}" target="_blank" rel="noopener noreferrer" aria-label="Share by Email"><span class="visuallyhidden">Email</span></a></li> | ||
<li><a class="social-media-sharer facebook" href="{{facebookUrl}}" target="_blank" rel="noopener noreferrer" aria-label="Share on Facebook"><span class="visuallyhidden">Facebook</span></a></li> | ||
<li><a class="social-media-sharer twitter" href="{{twitterUrl}}" target="_blank" rel="noopener noreferrer" aria-label="Tweet a link to this page"><span class="visuallyhidden">Twitter</span></a></li> | ||
<li><a class="social-media-sharer linkedin" href="{{linkedInUrl}}" target="_self" aria-label="Share this page to LinkedIn (opens up email program, if configured on this system)"><span class="visuallyhidden">LinkedIn</span></a></li> | ||
<li><a class="social-media-sharer reddit" href="{{redditUrl}}" target="_blank" rel="noopener noreferrer" aria-label="Share this page on Reddit"><span class="visuallyhidden">Reddit</span></a></li> | ||
</ul> |
8 changes: 6 additions & 2 deletions
8
source/_patterns/00-atoms/components/social-media-sharers.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,24 @@ | ||
$schema: http://json-schema.org/draft-04/schema# | ||
type: object | ||
properties: | ||
emailUrl: | ||
type: string | ||
format: uri | ||
facebookUrl: | ||
type: string | ||
format: uri | ||
twitterUrl: | ||
type: string | ||
format: uri | ||
emailUrl: | ||
linkedInUrl: | ||
type: string | ||
format: uri | ||
redditUrl: | ||
type: string | ||
format: uri | ||
required: | ||
- emailUrl | ||
- facebookUrl | ||
- twitterUrl | ||
- emailUrl | ||
- linkedInUrl | ||
- redditUrl |
3 changes: 2 additions & 1 deletion
3
source/_patterns/02-organisms/content-headers/content-header~article-1-author.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we be sure this won't adversely affect other elements with this class?