Share popup modal separation #1107
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor main article width/gutters to grid * Add DNA string for testing * Potential fix for long urls * Move article columns to article-section scss file * Refactor article section for secondary column
* Add table variations and fix bug for lists inside tables * Format code * Remove unwanted code * Reverting to original
* Add table variations and fix bug for lists inside tables * Format code * Remove unwanted code * Reverting to original * Update font, font-size for list items and paragraphs in tables
will-byrne
approved these changes
Feb 9, 2022
…es/pattern-library into share-popup-modal-separation
Need to check when merged into content header branch for right column
…es/pattern-library into share-popup-modal-separation
nlisgo
reviewed
Feb 23, 2022
nlisgo
reviewed
Feb 23, 2022
nlisgo
reviewed
Feb 23, 2022
nlisgo
reviewed
Feb 23, 2022
|
|
||
| .button { | ||
| justify-self: center; | ||
| margin-bottom: 24px; |
There was a problem hiding this comment.
There are a few cases where it would be appropriate to use a mixin such as here @include margin(24, "bottom");
There was a problem hiding this comment.
Had not finished this part of the changes
nlisgo
reviewed
Feb 23, 2022
nlisgo
reviewed
Feb 23, 2022
|
This was not ready for review as had not finished |
…to share-popup-modal-separation # Conflicts: # assets/js/components/ButtonClipboard.js # assets/js/components/Modal.js # assets/sass/patterns/atoms/modal-window.scss # source/_patterns/00-atoms/components/modal-window.mustache # source/_patterns/00-atoms/components/modal-window.yaml # source/_patterns/00-atoms/components/modal-window~citations.json # source/_patterns/00-atoms/components/modal-window~share.json # test/buttonclipboard.spec.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.