feat: clean and release PR Lookup #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
spruce-pr-lookup
branch
from
4a40022
to
02193eb
Compare
codebytere
force-pushed
the
spruce-pr-lookup
branch
3 times, most recently
from
106a8dc
to
9a5b085
Compare
codebytere
force-pushed
the
spruce-pr-lookup
branch
from
9a5b085
to
56980ca
Compare
ckerr
approved these changes
Dec 13, 2023
dsanders11
requested changes
Dec 13, 2023
There was a problem hiding this comment.
Overall excited for this, but a few fixes, and I'm worried about some security implications (see inline comment).
I think we should also bump the cache time on getPR and getPRComments which are both less than a minute currently - cold load time for a PR is fairly slow. Seems reasonable to cache these for longer - I'd be fine with an hour?
codebytere
force-pushed
the
spruce-pr-lookup
branch
from
f8c59a3
to
474bfd4
Compare
Co-authored-by: David Sanders <[email protected]>
codebytere
force-pushed
the
spruce-pr-lookup
branch
from
474bfd4
to
bb1fcef
Compare
codebytere
force-pushed
the
spruce-pr-lookup
branch
from
6e79ff4
to
998f11f
Compare
codebytere
force-pushed
the
spruce-pr-lookup
branch
from
3f4fc41
to
5fcc8d0
Compare
dsanders11
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25
This PR finishes an in-progress effort to display PR information to Electron developers. Being able to see PR information allows them to more easily determine if a given fix is in a version they've consumed without needing to peruse release notes, among other things.
There's definitely better error validation and other things to add to this but given folks are about to head to holiday i'd like to get this out the door before we all do! Some of the data parsing is also a bit off but this feature is intended to be a UI change.
Designed to take after https://chromiumdash.appspot.com/
PR Lookup View:
New PR View: